[GitHub] [solr] risdenk commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r996243783


##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
  */
 public class SolrCloudTestCase extends SolrTestCaseJ4 {
 
+
+  public static <T> void assertThat(T actual, Matcher<? super T> matcher) {

Review Comment:
   So we can't override assertThat in `SolrTestCase` since its static and comes from `Assert` which is what `LuceneTestCase` derives from. ForbiddenApis correctly complains that we can't just override the static method and instead knows that `Assert#assertThat` is still being called. So the solution in this PR isn't going to work as is. I'm working on an updated patch to handle this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org