You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jmesnil <gi...@git.apache.org> on 2016/04/07 10:18:17 UTC

[GitHub] activemq-artemis pull request: [ARTEMIS-472] add cause to AMQ22213...

GitHub user jmesnil opened a pull request:

    https://github.com/apache/activemq-artemis/pull/442

    [ARTEMIS-472] add cause to AMQ222137 warning

    JIRA: https://issues.apache.org/jira/browse/ARTEMIS-472

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-472_AMQ222137_warning

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #442
    
----
commit c113b910ed3618356cc24c65a0ff3afe80c7e105
Author: Jeff Mesnil <jm...@gmail.com>
Date:   2016-04-07T08:16:38Z

    [ARTEMIS-472] add cause to AMQ222137 warning
    
    JIRA: https://issues.apache.org/jira/browse/ARTEMIS-472

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: [ARTEMIS-472] add cause to AMQ22213...

Posted by jmesnil <gi...@git.apache.org>.
Github user jmesnil commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/442#issuecomment-206777033
  
    @mtaylor I amended the PR. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: [ARTEMIS-472] add cause to AMQ22213...

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/442#issuecomment-206770126
  
    @jmesnil The @Cause annotation will ensure that the exception is written to the log along with the message.  Adding @Cause, changes the parameter type, which means it can't be used as a positional format parameter within the message string.
    
    Could you just remove the change to the message. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: [ARTEMIS-472] add cause to AMQ22213...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/442


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---