You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/04 02:55:44 UTC
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #358: Feat release 1.5
juzhiyuan commented on a change in pull request #358:
URL: https://github.com/apache/apisix-dashboard/pull/358#discussion_r464768854
##########
File path: README.md
##########
@@ -36,28 +36,29 @@ The `manager-api` is used to provide APIs for Dashboard, just like a bridge betw
```sh
# e.g Initialization for MySQL
$ mysql –uroot –p123456
-> source apisix-dashboard/api/script/db/schema.sql
+> source $PROJECT_ROOT_FOLDER/api/script/db/schema.sql
```
2. Start the Apache APISIX.
[Please follow this guide](https://github.com/apache/apisix#configure-and-installation)
-3. Set environment variables
+3. Check environment variables
-According to your local deployment environment, modify the environment variables in `$PROJECT_ROOT_FOLDER/api/run/run.sh`
+According to your local deployment environment, check the environment variables in `$PROJECT_ROOT_FOLDER/api/run/run.sh`, modify the environment variables if necessary.
4. Build
```sh
-$ go build -o manager-api apisix-dashboard/api
+## make sure you are in the path of $PROJECT_ROOT_FOLDER
+$ go build -o manager-api ./api
```
5. Run
```sh
-$ chmod +x apisix-dashboard/api/run/run.sh
-$ sh apisix-dashboard/api/run/run.sh
+## make sure you are in the path of $PROJECT_ROOT_FOLDER
Review comment:
same issue here
##########
File path: README.md
##########
@@ -36,28 +36,29 @@ The `manager-api` is used to provide APIs for Dashboard, just like a bridge betw
```sh
# e.g Initialization for MySQL
$ mysql –uroot –p123456
-> source apisix-dashboard/api/script/db/schema.sql
+> source $PROJECT_ROOT_FOLDER/api/script/db/schema.sql
Review comment:
Please use `apisix-dashboard` instead.
##########
File path: README.md
##########
@@ -36,28 +36,29 @@ The `manager-api` is used to provide APIs for Dashboard, just like a bridge betw
```sh
# e.g Initialization for MySQL
$ mysql –uroot –p123456
-> source apisix-dashboard/api/script/db/schema.sql
+> source $PROJECT_ROOT_FOLDER/api/script/db/schema.sql
```
2. Start the Apache APISIX.
[Please follow this guide](https://github.com/apache/apisix#configure-and-installation)
-3. Set environment variables
+3. Check environment variables
-According to your local deployment environment, modify the environment variables in `$PROJECT_ROOT_FOLDER/api/run/run.sh`
+According to your local deployment environment, check the environment variables in `$PROJECT_ROOT_FOLDER/api/run/run.sh`, modify the environment variables if necessary.
4. Build
```sh
-$ go build -o manager-api apisix-dashboard/api
+## make sure you are in the path of $PROJECT_ROOT_FOLDER
Review comment:
@moonming recommends we should use `apisix-dashboard` here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org