You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jp...@apache.org on 2018/07/18 02:19:06 UTC
mesos git commit: Disabled the clang
`-Winconsistent-missing-override` warning.
Repository: mesos
Updated Branches:
refs/heads/master d52a89802 -> 51121a03c
Disabled the clang `-Winconsistent-missing-override` warning.
Clang can emit a `-Winconsistent-missing-override` warning for most
uses of the Google Mock `MOCK_METHOD` family of macros. See also
https://github.com/google/googletest/issues/533.
Review: https://reviews.apache.org/r/67953/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/51121a03
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/51121a03
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/51121a03
Branch: refs/heads/master
Commit: 51121a03ccc8db59adf1bf8d43079aaa4c917b7e
Parents: d52a898
Author: James Peach <jp...@apache.org>
Authored: Tue Jul 17 19:17:50 2018 -0700
Committer: James Peach <jp...@apache.org>
Committed: Tue Jul 17 19:17:50 2018 -0700
----------------------------------------------------------------------
cmake/CompilationConfigure.cmake | 3 +++
configure.ac | 2 ++
2 files changed, 5 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/51121a03/cmake/CompilationConfigure.cmake
----------------------------------------------------------------------
diff --git a/cmake/CompilationConfigure.cmake b/cmake/CompilationConfigure.cmake
index 49b2dc0..f80c265 100644
--- a/cmake/CompilationConfigure.cmake
+++ b/cmake/CompilationConfigure.cmake
@@ -332,6 +332,9 @@ elseif (CMAKE_CXX_COMPILER_ID MATCHES MSVC)
/w44267)
endif ()
+if (CMAKE_CXX_COMPILER_ID MATCHES Clang)
+ add_compile_options(-Wno-inconsistent-missing-override)
+endif ()
# POSIX CONFIGURATION.
######################
http://git-wip-us.apache.org/repos/asf/mesos/blob/51121a03/configure.ac
----------------------------------------------------------------------
diff --git a/configure.ac b/configure.ac
index 5f64168..e86c496 100644
--- a/configure.ac
+++ b/configure.ac
@@ -648,6 +648,8 @@ AS_CASE($ax_cv_cxx_compiler_vendor,
AC_MSG_NOTICE([Disabling warnings about unused local typedefs])
CXXFLAGS="${CXXFLAGS} -Wno-unused-local-typedef"
fi
+
+ CXXFLAGS="${CXXFLAGS} -Wno-inconsistent-missing-override"
], [gnu], [
# Check for GCC version >= 4.8.
AX_COMPARE_VERSION([$ax_cv_cxx_compiler_version], [ge], [4.8],