Re: Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

[Jacques Nadeau <ja...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34603/#review86237
-----------------------------------------------------------

Ship it!


Looks good.  One change I suggest is changing the user display in the web tier to show "FAILED" rather than "FAILING" so people aren't confused.

- Jacques Nadeau


On May 22, 2015, 5:42 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34603/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 5:42 p.m.)
> 
> 
> Review request for drill, Chris Westin, Jacques Nadeau, and Sudheesh Katkam.
> 
> 
> Bugs: DRILL-3167
>     https://issues.apache.org/jira/browse/DRILL-3167
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - In case of a failure the Foreman will cancel all fragments and move to a FAILING state until all fragments are terminated
> - QueryManager.cancelExecutingFragments() returns false if no fragment available
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 5d07b49 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 71b77c6 
>   protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java 92afa4f 
>   protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryResult.java 474e330 
>   protocol/src/main/protobuf/UserBitShared.proto 68c8612 
> 
> Diff: https://reviews.apache.org/r/34603/diff/
> 
> 
> Testing
> -------
> 
> unit tests are passing
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>