You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2022/12/28 09:10:11 UTC

[servicecomb-java-chassis] branch master updated: [SCB-2737]do not print swagger contents to logs any more

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new cf7279708 [SCB-2737]do not print swagger contents to logs any more
cf7279708 is described below

commit cf7279708760f7210860952cd6a62bf9ee1d42b0
Author: liubao <bi...@qq.com>
AuthorDate: Wed Dec 28 16:47:28 2022 +0800

    [SCB-2737]do not print swagger contents to logs any more
---
 .../provider/producer/ProducerBootListener.java    | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerBootListener.java b/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerBootListener.java
index b37f11cc3..1242ad139 100644
--- a/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerBootListener.java
+++ b/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerBootListener.java
@@ -50,16 +50,20 @@ public class ProducerBootListener implements BootListener {
   private static final Logger LOGGER = LoggerFactory.getLogger(ProducerBootListener.class);
 
   private static final String PATTERN = File.separator + "microservices"
-          + File.separator + "%s" + File.separator + "%s.yaml";
+      + File.separator + "%s" + File.separator + "%s.yaml";
 
   private static final String TMP_DIR = System.getProperty("java.io.tmpdir");
 
   @Override
   public void onAfterTransport(BootEvent event) {
     boolean exportToFile = DynamicPropertyFactory.getInstance()
-            .getBooleanProperty(DefinitionConst.SWAGGER_EXPORT_ENABLED, true).get();
+        .getBooleanProperty(DefinitionConst.SWAGGER_EXPORT_ENABLED, true).get();
     String filePath = DynamicPropertyFactory.getInstance()
-            .getStringProperty(DefinitionConst.SWAGGER_DIRECTORY, TMP_DIR).get() + PATTERN;
+        .getStringProperty(DefinitionConst.SWAGGER_DIRECTORY, TMP_DIR).get() + PATTERN;
+
+    if (exportToFile) {
+      LOGGER.info("export microservice swagger file to path {}", filePath);
+    }
     // register schema to microservice;
     Microservice microservice = RegistrationManager.INSTANCE.getMicroservice();
 
@@ -78,13 +82,13 @@ public class ProducerBootListener implements BootListener {
       String content = SwaggerUtils.swaggerToString(swagger);
       if (exportToFile) {
         exportToFile(String.format(filePath, microservice.getServiceName(), schemaMeta.getSchemaId()), content);
+      } else {
+        LOGGER.info("generate swagger for {}/{}/{}, swagger: {}",
+            microserviceMeta.getAppId(),
+            microserviceMeta.getMicroserviceName(),
+            schemaMeta.getSchemaId(),
+            content);
       }
-      LOGGER.info("generate swagger for {}/{}/{}, swagger: {}",
-          microserviceMeta.getAppId(),
-          microserviceMeta.getMicroserviceName(),
-          schemaMeta.getSchemaId(),
-          content);
-
       RegistrationManager.INSTANCE.addSchema(schemaMeta.getSchemaId(), content);
     }