You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/14 14:28:01 UTC

[GitHub] [hbase] wchevreuil commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible

wchevreuil commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#issuecomment-574199277
 
 
   Thanks for the reviews @bharathv, @binlijin and @joshelser. 
   
   > Maybe something we should lift up to an abstract and limited-private base class later? Looks like HBASE-15982 made this private in 2.0.0 (intentionally). So, maybe any further refactoring would be more complicated than I initially thought :)
   
   Did notice that, but then the whole hierarchy from _BaseReplicationEndpoint_ downwards is marked as such. As you said, there could be some extra refactoring. I'm not sure why it has been made private by HBASE-15982, was it because there are still plans to move out from the guava service API dependency?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services