[GitHub] [hbase] saintstack commented on a change in pull request #864: HBASE-23313 [hbck2] setRegionState should update Master in-memory sta…

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #864: HBASE-23313 [hbck2] setRegionState should update Master in-memory sta…
URL: https://github.com/apache/hbase/pull/864#discussion_r349697648
 
 

 ##########
 File path: hbase-protocol-shaded/src/main/protobuf/Master.proto
 ##########
 @@ -1152,6 +1161,10 @@ service HbckService {
   rpc SetTableStateInMeta(SetTableStateInMetaRequest)
     returns(GetTableStateResponse);
 
+  /** Update state of the table in meta only*/
+  rpc SetRegionStateInMeta(SetRegionStateInMetaRequest)
+    returns(GetRegionStateResponse);
 
 Review comment:
   I see this pattern setting table state where there we reused a GetTableStateResponse as return from SetTableState method. Usually the reponse has same prefix as request -- i.e. the name of the method. I suppose this is ok. Maybe one day we'll have a method that just queries the method state and when that is added, we'll need this GetRegionStateResponse again.
   
   Just noting that this is breaking the general pattern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services