You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/03/03 06:09:38 UTC
[GitHub] zeppelin pull request #2092: [ZEPPELIN-2148] On creation of Bar graph zeppel...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2092
[ZEPPELIN-2148] On creation of Bar graph zeppelin UI shows it as minigraph - 2
### What is this PR for?
This is based on https://github.com/apache/zeppelin/pull/2074#issuecomment-283843330.
In this I've reverted #47a106a and applied, that.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### What is the Jira issue?
* [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148)
### How should this be tested?
Check screen shot.
### Screenshots (if appropriate)
Before:
After:
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2148-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2092.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2092
----
commit 5062c0bc4b3899e66a8b89dcff2ac0cb091a5a1d
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-03-03T05:55:16Z
ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph
### What is this PR for?
On creation of Bar graph zeppelin UI shows it as mini graph, and is easily reproducible on safari.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148)
### How should this be tested?
Check screen shot.
### Screenshots (if appropriate)
Before:
After:
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
Author: Prabhjyot Singh <pr...@gmail.com>
Closes #2063 from prabhjyotsingh/ZEPPELIN-2148 and squashes the following commits:
bb66897 [Prabhjyot Singh] replace setTimeOut with $timeout
38a1198 [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph (reverted from commit 47a106ab9840555f85416cc08e17ee092b5cecdf)
commit bdd0b26a93f78656e973263fba94bf048da4beb4
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-03-03T06:06:44Z
apply https://github.com/apache/zeppelin/pull/2074
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2092: [ZEPPELIN-2148] On creation of Bar graph zeppelin UI s...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2092
Thank you @1ambda.
Will merge this soon based on reviews in https://github.com/apache/zeppelin/pull/2074.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2092: [ZEPPELIN-2148] On creation of Bar graph zeppelin UI s...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2092
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2092: [ZEPPELIN-2148] On creation of Bar graph zeppel...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2092
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---