You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "Maxxx873 (via GitHub)" <gi...@apache.org> on 2023/06/23 20:09:22 UTC
[GitHub] [james-project] Maxxx873 opened a new pull request, #1606: JAMES-2434 IsFromMailingList matcher
Maxxx873 opened a new pull request, #1606:
URL: https://github.com/apache/james-project/pull/1606
* Implemented IsFromMailingList matcher with using AutomaticallySentMailDetector::isMailingList utility. This matcher returns recipients of the mail if the mail is from a mailing list.
* Fixed IsSingleRecipient matcher - for methods that return an array, prefer returning an empty array over a null value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1606: JAMES-2434 IsFromMailingList matcher
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #1606:
URL: https://github.com/apache/james-project/pull/1606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Maxxx873 commented on pull request #1606: JAMES-2434 IsFromMailingList matcher
Posted by "Maxxx873 (via GitHub)" <gi...@apache.org>.
Maxxx873 commented on PR #1606:
URL: https://github.com/apache/james-project/pull/1606#issuecomment-1606575212
> ```
> 20:46:20,494 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project apache-mailet-standard: You have 2 Checkstyle violations. -> [Help 1]
> ```
>
> There is some checkstyle issue with your code (we have a maven plugin doing some strict code style checking following this file: https://github.com/apache/james-project/blob/master/checkstyle.xml during the build)
>
> I would guess likely some unused imports in the files in your PR that you added/modified. Please help fixing this :)
Sorry, I'm just used to a different import order :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1606: JAMES-2434 IsFromMailingList matcher
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1606:
URL: https://github.com/apache/james-project/pull/1606#discussion_r1240756122
##########
mailet/standard/src/test/java/org/apache/james/transport/matchers/IsFromMailingListTest.java:
##########
@@ -0,0 +1,50 @@
+package org.apache.james.transport.matchers;
Review Comment:
You are missing the compulsary Apache V2 license header comment in this file.
##########
mailet/standard/src/main/java/org/apache/james/transport/matchers/IsFromMailingList.java:
##########
@@ -0,0 +1,48 @@
+package org.apache.james.transport.matchers;
Review Comment:
You are missing the compulsary Apache V2 license header comment in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1606: JAMES-2434 IsFromMailingList matcher
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1606:
URL: https://github.com/apache/james-project/pull/1606#issuecomment-1606585182
> Sorry, I'm just used to a different import order :)
No worries :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1606: JAMES-2434 IsFromMailingList matcher
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1606:
URL: https://github.com/apache/james-project/pull/1606#issuecomment-1606546278
```
20:46:20,494 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project apache-mailet-standard: You have 2 Checkstyle violations. -> [Help 1]
```
There is some checkstyle issue with your code (we have a maven plugin doing some strict code style checking following this file: https://github.com/apache/james-project/blob/master/checkstyle.xml during the build)
I would guess likely some unused imports in the files in your PR that you added/modified. Please help fixing this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Maxxx873 commented on pull request #1606: JAMES-2434 IsFromMailingList matcher
Posted by "Maxxx873 (via GitHub)" <gi...@apache.org>.
Maxxx873 commented on PR #1606:
URL: https://github.com/apache/james-project/pull/1606#issuecomment-1605725513
> 2 licenses to add but overall thanks for this great contribution!
Thank you for taking the time to review my code. I appreciate your feedback and will use it to improve my work in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org