You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/31 15:13:05 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #670: Check
return from nxsem_wait_initialize()
patacongo opened a new pull request #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670
Resolution of Issue 619 will require multiple steps, this part of the first step in that resolution: Every call to nxsem_wait_uninterruptible() must handle the return value from nxsem_wait_uninterruptible properly. This commit is only for those files under drivers/audio, drivers/net, and drivers/lcd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #670: Check
return from nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670#issuecomment-606692023
NOTE to Reviewer: This PR will fail the nxstyle check because it used definitions from include/fixedmath.h of the form b16HALF. Either nxstyle or many, many files would have to change to eliminate that complaint.
Please ignore those reports from nxstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #670: Check return
from nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670#issuecomment-606777393
I updated nxstyle with PR #672 so that it does not report the "Mixed case identifier" on the fixedmath.h definitions. However, there are still severl mixed case identier reports on msgId which is a field in a structure defined by the audio system and in broader use outside of these changed files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #670: Check return from
nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670#issuecomment-606740481
The build tests run independently of the status of the style check.
There are other build failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #670: Check return
from nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670#issuecomment-606699670
unfortunately the patch contains nxstyle changes and the actual patch
I think that it would be better if in the future we split the commits in 2 patches nxstyle changes and the actual patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #670: Check
return from nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on issue #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670#issuecomment-606699670
unfortunately the patch contains nxstyle changes and the actual patch which makes it harder to review
I think that it would be better if in the future we split the commits in 2 patches nxstyle changes and the actual patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #670: Check return
from nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670#issuecomment-606757090
> There are other build failures.
I think these have been addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #670: Check
return from nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670#issuecomment-606692023
NOTE to Reviewer: This PR will fail the nxstyle check because it used definitions from include/fixedmath.h of the form b16HALF. Either nxstyle or many, many files would have to change to eliminate that complaint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #670: Check return from
nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #670: Check return
from nxsem_wait_initialize()
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #670: Check return from nxsem_wait_initialize()
URL: https://github.com/apache/incubator-nuttx/pull/670#issuecomment-606692023
NOTE to Reviewer: This PR will fail the nxstyle check because it used definitions from include /fixedmath.h of the form b16HALF. Either nxstyle or many, many files would have to change to eliminate that complaint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services