You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/26 01:05:31 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7570: Support k8s configmap grouped dynamic configurations

wu-sheng commented on a change in pull request #7570:
URL: https://github.com/apache/skywalking/pull/7570#discussion_r696212586



##########
File path: oap-server/server-configuration/configuration-k8s-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigurationConfigmapInformer.java
##########
@@ -37,7 +42,7 @@
 
 @Slf4j
 public class ConfigurationConfigmapInformer {
-
+    private final static String LABEL_SW_GROUP_CONFIG_KEY = "sw-group-config-key";

Review comment:
       It is better to make this label configurable. Take `ClusterModuleKubernetesConfig` as a reference.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org