[GitHub] [iceberg] namrathamyske commented on a diff in pull request #4926: Core, API: Performing operations on a snapshot branch ref

[GitBox <gi...@apache.org>]

namrathamyske commented on code in PR #4926:
URL: https://github.com/apache/iceberg/pull/4926#discussion_r893928402


##########
api/src/main/java/org/apache/iceberg/SnapshotUpdate.java:
##########
@@ -60,4 +60,9 @@
    * @return this for method chaining
    */
   ThisT scanManifestsWith(ExecutorService executorService);
+
+  /**
+   * Perform operations a particular branch

Review Comment:
   @rdblue  i added a check to check if branch exists. If it does not exist should we create new branch? I was thinking to throw an illegal arg exception.
   
   _How does this change validation? What if the validation's from snapshot is not an ancestor of the branch? - > I did not understand this scenario._



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org