You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mylog00 <gi...@git.apache.org> on 2017/07/15 16:04:35 UTC
[GitHub] flink pull request #4349: [FLINK-7127] [runtime] Remove unnecessary null che...
GitHub user mylog00 opened a pull request:
https://github.com/apache/flink/pull/4349
[FLINK-7127] [runtime] Remove unnecessary null check or add null check;
To avoid NPE I decided add null check instead remove it one.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mylog00/flink FLINK-7127
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4349
----
commit 9370470b4674d414e9fd0d1f6146a4a9de92cc70
Author: Dmitrii Kniazev <my...@ya.ru>
Date: 2017-07-10T18:41:32Z
[FLINK-7127] [runtime] Remove unnecessary null check or add null check;
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4349
One other thing:
For commit messages, they should convey the exact final fix.
So, instead of "Remove unnecessary null check OR add null check", it should simply state how it is fixed. I'll adjust it appropriately this time for you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4349: [FLINK-7127] [runtime] Remove unnecessary null che...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...
Posted by mylog00 <gi...@git.apache.org>.
Github user mylog00 commented on the issue:
https://github.com/apache/flink/pull/4349
Thanks for the advice. I will not repeat this mistake again in the future :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4349
Thanks for the fix!
LGTM, merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...
Posted by mylog00 <gi...@git.apache.org>.
Github user mylog00 commented on the issue:
https://github.com/apache/flink/pull/4349
Link to passed tests build: https://travis-ci.org/mylog00/flink/builds/253949055
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---