You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/27 21:40:51 UTC
[GitHub] [beam] lukecwik opened a new pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
lukecwik opened a new pull request #12706:
URL: https://github.com/apache/beam/pull/12706
I used the UnboundedSourceFunction as a guide to implementing the bundle finalization hook for the DoFnOperator.
Since checkpointing support is only supported when using shutdownSourcesAfterIdleMs so I added a new validates runner task that runs a subset of the tests that rely on bundle finalization.
I also added support for Impulse translation for non-portable streaming pipelines.
This is the base for swapping over non-portable Flink to use SDF instead of UnboundedSources.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace
--- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik merged pull request #12706:
URL: https://github.com/apache/beam/pull/12706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12706:
URL: https://github.com/apache/beam/pull/12706#issuecomment-682851812
Run Flink ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on a change in pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
mxm commented on a change in pull request #12706:
URL: https://github.com/apache/beam/pull/12706#discussion_r478904282
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -191,6 +194,17 @@
private final boolean finishBundleBeforeCheckpointing;
+ /** Stores new finalizations being gathered. */
+ private transient InMemoryBundleFinalizer bundleFinalizer;
+ /** Pending bundle finalizations which have not been acknowledged yet. */
+ private transient LinkedHashMap<Long, List<InMemoryBundleFinalizer.Finalization>>
+ pendingFinalizations;
+ /**
+ * Keep a maximum of 32 bundle finalizations for {@link
+ * BundleFinalizer.Callback#onBundleSuccess()}.
+ */
+ private static final int MAX_NUMBER_PENDING_BUNDLE_FINALIZATIONS = 32;
Review comment:
This constant appears to be unused.
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -905,6 +928,19 @@ public final void notifyCheckpointComplete(long checkpointId) throws Exception {
bufferingDoFnRunner.checkpointCompleted(checkpointId);
}
+ List<InMemoryBundleFinalizer.Finalization> finalizations =
+ pendingFinalizations.get(checkpointId);
+ if (finalizations != null) {
+ // remove old finalizations except for the current one
+ pendingFinalizations.clear();
+ pendingFinalizations.put(checkpointId, finalizations);
+
+ // confirm all finalizations
+ for (InMemoryBundleFinalizer.Finalization finalization : finalizations) {
+ finalization.getCallback().onBundleSuccess();
Review comment:
Acknowledging the latest bundle finalize will also acknowledge all earlier requests for bundle finalization?
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -905,6 +928,19 @@ public final void notifyCheckpointComplete(long checkpointId) throws Exception {
bufferingDoFnRunner.checkpointCompleted(checkpointId);
}
+ List<InMemoryBundleFinalizer.Finalization> finalizations =
+ pendingFinalizations.get(checkpointId);
+ if (finalizations != null) {
+ // remove old finalizations except for the current one
+ pendingFinalizations.clear();
Review comment:
The default is to have just one checkpoint at a given time, but users can configure concurrent checkpointing which can ack checkpoints out of order.
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -905,6 +928,19 @@ public final void notifyCheckpointComplete(long checkpointId) throws Exception {
bufferingDoFnRunner.checkpointCompleted(checkpointId);
}
+ List<InMemoryBundleFinalizer.Finalization> finalizations =
+ pendingFinalizations.get(checkpointId);
+ if (finalizations != null) {
+ // remove old finalizations except for the current one
+ pendingFinalizations.clear();
+ pendingFinalizations.put(checkpointId, finalizations);
Review comment:
Why is this one pending when we acknowledge it below?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12706:
URL: https://github.com/apache/beam/pull/12706#issuecomment-683165741
@mxm This is ready for another round of review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a change in pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #12706:
URL: https://github.com/apache/beam/pull/12706#discussion_r479379349
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -905,6 +928,19 @@ public final void notifyCheckpointComplete(long checkpointId) throws Exception {
bufferingDoFnRunner.checkpointCompleted(checkpointId);
}
+ List<InMemoryBundleFinalizer.Finalization> finalizations =
+ pendingFinalizations.get(checkpointId);
+ if (finalizations != null) {
+ // remove old finalizations except for the current one
+ pendingFinalizations.clear();
+ pendingFinalizations.put(checkpointId, finalizations);
Review comment:
I was basing my logic off of UnboundedSourceWrapper which seemed flawed but didn't know enough as to why it was done that way there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik merged pull request #12706:
URL: https://github.com/apache/beam/pull/12706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a change in pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #12706:
URL: https://github.com/apache/beam/pull/12706#discussion_r479379349
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -905,6 +928,19 @@ public final void notifyCheckpointComplete(long checkpointId) throws Exception {
bufferingDoFnRunner.checkpointCompleted(checkpointId);
}
+ List<InMemoryBundleFinalizer.Finalization> finalizations =
+ pendingFinalizations.get(checkpointId);
+ if (finalizations != null) {
+ // remove old finalizations except for the current one
+ pendingFinalizations.clear();
+ pendingFinalizations.put(checkpointId, finalizations);
Review comment:
I was basing my logic off of UnboundedSourceWrapper which seemed flawed but didn't know enough as to why it was done that way there but now I understand what the UnboundedSourceWrapper was doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a change in pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #12706:
URL: https://github.com/apache/beam/pull/12706#discussion_r479377197
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -191,6 +194,17 @@
private final boolean finishBundleBeforeCheckpointing;
+ /** Stores new finalizations being gathered. */
+ private transient InMemoryBundleFinalizer bundleFinalizer;
+ /** Pending bundle finalizations which have not been acknowledged yet. */
+ private transient LinkedHashMap<Long, List<InMemoryBundleFinalizer.Finalization>>
+ pendingFinalizations;
+ /**
+ * Keep a maximum of 32 bundle finalizations for {@link
+ * BundleFinalizer.Callback#onBundleSuccess()}.
+ */
+ private static final int MAX_NUMBER_PENDING_BUNDLE_FINALIZATIONS = 32;
Review comment:
I forgot to add the clean-up logic bounding how many there could be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a change in pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #12706:
URL: https://github.com/apache/beam/pull/12706#discussion_r479380433
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -905,6 +928,19 @@ public final void notifyCheckpointComplete(long checkpointId) throws Exception {
bufferingDoFnRunner.checkpointCompleted(checkpointId);
}
+ List<InMemoryBundleFinalizer.Finalization> finalizations =
+ pendingFinalizations.get(checkpointId);
+ if (finalizations != null) {
+ // remove old finalizations except for the current one
+ pendingFinalizations.clear();
Review comment:
I see, I was basing the logic on UnboundedSourceWrapper but I have removed it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a change in pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #12706:
URL: https://github.com/apache/beam/pull/12706#discussion_r479380211
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -905,6 +928,19 @@ public final void notifyCheckpointComplete(long checkpointId) throws Exception {
bufferingDoFnRunner.checkpointCompleted(checkpointId);
}
+ List<InMemoryBundleFinalizer.Finalization> finalizations =
+ pendingFinalizations.get(checkpointId);
+ if (finalizations != null) {
+ // remove old finalizations except for the current one
+ pendingFinalizations.clear();
+ pendingFinalizations.put(checkpointId, finalizations);
+
+ // confirm all finalizations
+ for (InMemoryBundleFinalizer.Finalization finalization : finalizations) {
+ finalization.getCallback().onBundleSuccess();
Review comment:
Between two checkpoint boundaries, the DoFn may have requested multiple finalizations (e.g. one per element processed) each having a different side effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12706:
URL: https://github.com/apache/beam/pull/12706#issuecomment-682205584
R: @mxm @tweise
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12706:
URL: https://github.com/apache/beam/pull/12706#issuecomment-690412215
R: @tysonjh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12706: [BEAM-6868, BEAM-10670] Add support for bundle finalization to DoFnOperator for non-portable streaming pipelines.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12706:
URL: https://github.com/apache/beam/pull/12706#issuecomment-682205350
Run Flink ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org