You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "Aditya Sharma (JIRA)" <ji...@apache.org> on 2018/12/26 08:39:00 UTC

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

    [ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728930#comment-16728930 ] 

Aditya Sharma commented on OFBIZ-10725:
---------------------------------------

Improves code in methods:
isPrimaryKey() of GenericEntity

hasNext() and hasPrevious() of EntityListIterator
isValueActive() of EntityUtil
 
Additional change:
Improved return for getStartIndexFromViewIndex() method in EntityUtil. Instead of using if-else block, a ternary operator is used for improving readability.
Done for trunk at R1849741.

> Refactor boolean returns from methods
> -------------------------------------
>
>                 Key: OFBIZ-10725
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10725
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Aditya Sharma
>            Assignee: Aditya Sharma
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)