You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/02 09:24:46 UTC

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2022: fix(route): add operators

juzhiyuan commented on a change in pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#discussion_r680814518



##########
File path: web/src/pages/Route/components/Step1/MatchingRulesView.tsx
##########
@@ -88,6 +88,18 @@ const MatchingRulesView: React.FC<RouteModule.Step1PassProps> = ({
     });
   };
 
+  const OperatorRenderText = {
+    '==': 'page.route.equal',

Review comment:
       Not a good idea to use `key` here directly, I would prefer keeping the `formatMessage(xxx)` here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org