You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/20 09:14:19 UTC
[GitHub] [cloudstack] DaanHoogland commented on pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)
DaanHoogland commented on pull request #5216:
URL: https://github.com/apache/cloudstack/pull/5216#issuecomment-902555234
@atrocitytheme I like the premise and most of your implementation. Two worries:
1. your methods in `SnapshotManagerImpl` and in `UserVmManagerImpl` are rather long, Can you please extract sensible parts from them (and maybe at times re-use). A good indicator would be if there is a comment, it can probably be used as a camelCase method name and the code below it moved in the new method.
2. will the usage server pick up cloned machines for billing? (I don't think it will but I might be missing something)
thanks for this PR, good addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org