You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2014/04/26 20:18:26 UTC

svn commit: r1590270 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java

Author: liyin
Date: Sat Apr 26 18:18:26 2014
New Revision: 1590270

URL: http://svn.apache.org/r1590270
Log:
[master] Let HLogPrettyPrinter output real timestamp value

Author: fan

Summary: Currently timestamp is parsed and printed as a Date. The formatted date could not be directly used for debugging and it could not handle timestamps in nano seconds.

Test Plan: Run HLog class to parse HLog file.

Reviewers: adela, daviddeng, gauravm, liyintang, manukranthk, elliott, rshroff, aaiyer, jiqingt, mycnyc

Reviewed By: jiqingt

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1297068

Modified:
    hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java

Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java?rev=1590270&r1=1590269&r2=1590270&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java Sat Apr 26 18:18:26 2014
@@ -414,8 +414,9 @@ public class HLogPrettyPrinter {
               out.println("    row: " + op.get("row"));
               out.println("    column: " + op.get("family") + ":"
                   + op.get("qualifier"));
+              Long ts = (Long)op.get("timestamp");
               out.println("    at time: "
-                  + (new Date((Long) op.get("timestamp"))));
+                  + (new Date(ts)) + " (" + ts + ")");
               if (outputValues)
                 out.println("    value: " + op.get("value"));
             }