You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/07/04 13:33:24 UTC
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/
-----------------------------------------------------------
(Updated July 4, 2016, 7:03 p.m.)
Review request for lens.
Bugs: LENS-1207
https://issues.apache.org/jira/browse/LENS-1207
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/error/GenericExceptionMapper.java 9aa74ed0b9e1b7d03d2036e4c39497849bfed118
lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
Diff: https://reviews.apache.org/r/49374/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/
-----------------------------------------------------------
(Updated July 19, 2016, 3:59 p.m.)
Review request for lens.
Bugs: LENS-1207
https://issues.apache.org/jira/browse/LENS-1207
Repository: lens
Description
-------
Changes:
1. Make password optional in login
2. Add db as login parameter, just like java/python clients
3. By default only show base cubes. Can be configured to show all.
4. Modified start/stop scripts so that start is `npm start` and stop is `npm stop`
5. Lens server url and ui port is configurable by `.npmrc` now.
6. URLs changed. Now db is not part of the url, it's a session property, and is also cached in the client state
7. Reduced width of sidebar and increased width of main content
8. Corrected content in cube schema view. Now it shows joinchains and expressions too. Also, changed columns being displayed in measure and dimtable list.
9. Some bugfixes in error json parsing.
Diffs (updated)
-----
lens-ui/app/actions/LoginActions.js 3cb39d0ce4b4de3bb8b1075658f54d4f29798162
lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
lens-ui/app/adapters/AuthenticationAdapter.js 15c196b7f0dcbed426b1af0973ba6c4cc088ad9c
lens-ui/app/app.js 07d9acf2872590b971f5b66e07e35834bba42ec0
lens-ui/app/components/AdhocQueryComponent.js aae823c93210f006118ae61a438ebd35fc0db8c4
lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
lens-ui/app/components/LoginComponent.js 23b3bb94eebdc7c1da0e5b0302b2e0402d5621b1
lens-ui/app/components/QueryBoxComponent.js 30eb643c0faa24ac869741c26f4a60247ed6a865
lens-ui/app/components/TableTreeComponent.js 9a8351e763bf2849e35ba5c9dc7b63ec4d7528ff
lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
lens-ui/app/stores/DatabaseStore.js a18e98657aad287e4aeeba7c283d44f2665b2792
lens-ui/app/stores/UserStore.js 1d7e5d4710df01303211f219cf949c00515276a5
lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
lens-ui/package.json 0ed3db182c59d9744610a01ce8fc927161dda499
lens-ui/server.js c8920f381df477a42ee4147fd98c6cde8b3ed209
Diff: https://reviews.apache.org/r/49374/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/#review142719
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On July 12, 2016, 11:11 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49374/
> -----------------------------------------------------------
>
> (Updated July 12, 2016, 11:11 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1207
> https://issues.apache.org/jira/browse/LENS-1207
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes:
>
> 1. Make password optional in login
> 2. Add db as login parameter, just like java/python clients
> 3. By default only show base cubes. Can be configured to show all.
> 4. Modified start/stop scripts so that start is `npm start` and stop is `npm stop`
> 5. Lens server url and ui port is configurable by `.npmrc` now.
> 6. URLs changed. Now db is not part of the url, it's a session property, and is also cached in the client state
> 7. Reduced width of sidebar and increased width of main content
> 8. Corrected content in cube schema view. Now it shows joinchains and expressions too. Also, changed columns being displayed in measure and dimtable list.
> 9. Some bugfixes in error json parsing.
>
>
> Diffs
> -----
>
> lens-ui/app/actions/LoginActions.js 3cb39d0ce4b4de3bb8b1075658f54d4f29798162
> lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
> lens-ui/app/adapters/AuthenticationAdapter.js 15c196b7f0dcbed426b1af0973ba6c4cc088ad9c
> lens-ui/app/app.js 07d9acf2872590b971f5b66e07e35834bba42ec0
> lens-ui/app/components/AdhocQueryComponent.js aae823c93210f006118ae61a438ebd35fc0db8c4
> lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
> lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
> lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
> lens-ui/app/components/LoginComponent.js 23b3bb94eebdc7c1da0e5b0302b2e0402d5621b1
> lens-ui/app/components/QueryBoxComponent.js 30eb643c0faa24ac869741c26f4a60247ed6a865
> lens-ui/app/components/TableTreeComponent.js 9a8351e763bf2849e35ba5c9dc7b63ec4d7528ff
> lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
> lens-ui/app/stores/DatabaseStore.js a18e98657aad287e4aeeba7c283d44f2665b2792
> lens-ui/app/stores/UserStore.js 1d7e5d4710df01303211f219cf949c00515276a5
> lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
> lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
> lens-ui/package.json 0ed3db182c59d9744610a01ce8fc927161dda499
> lens-ui/server.js c8920f381df477a42ee4147fd98c6cde8b3ed209
>
> Diff: https://reviews.apache.org/r/49374/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/
-----------------------------------------------------------
(Updated July 12, 2016, 4:41 p.m.)
Review request for lens.
Bugs: LENS-1207
https://issues.apache.org/jira/browse/LENS-1207
Repository: lens
Description
-------
Changes:
1. Make password optional in login
2. Add db as login parameter, just like java/python clients
3. By default only show base cubes. Can be configured to show all.
4. Modified start/stop scripts so that start is `npm start` and stop is `npm stop`
5. Lens server url and ui port is configurable by `.npmrc` now.
6. URLs changed. Now db is not part of the url, it's a session property, and is also cached in the client state
7. Reduced width of sidebar and increased width of main content
8. Corrected content in cube schema view. Now it shows joinchains and expressions too. Also, changed columns being displayed in measure and dimtable list.
9. Some bugfixes in error json parsing.
Diffs (updated)
-----
lens-ui/app/actions/LoginActions.js 3cb39d0ce4b4de3bb8b1075658f54d4f29798162
lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
lens-ui/app/adapters/AuthenticationAdapter.js 15c196b7f0dcbed426b1af0973ba6c4cc088ad9c
lens-ui/app/app.js 07d9acf2872590b971f5b66e07e35834bba42ec0
lens-ui/app/components/AdhocQueryComponent.js aae823c93210f006118ae61a438ebd35fc0db8c4
lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
lens-ui/app/components/LoginComponent.js 23b3bb94eebdc7c1da0e5b0302b2e0402d5621b1
lens-ui/app/components/QueryBoxComponent.js 30eb643c0faa24ac869741c26f4a60247ed6a865
lens-ui/app/components/TableTreeComponent.js 9a8351e763bf2849e35ba5c9dc7b63ec4d7528ff
lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
lens-ui/app/stores/DatabaseStore.js a18e98657aad287e4aeeba7c283d44f2665b2792
lens-ui/app/stores/UserStore.js 1d7e5d4710df01303211f219cf949c00515276a5
lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
lens-ui/package.json 0ed3db182c59d9744610a01ce8fc927161dda499
lens-ui/server.js c8920f381df477a42ee4147fd98c6cde8b3ed209
Diff: https://reviews.apache.org/r/49374/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/#review141885
-----------------------------------------------------------
Can you update doc on install_and_run apt file as well? We can remove doc corresponding to static ui.
- Amareshwari Sriramadasu
On July 12, 2016, 11:06 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49374/
> -----------------------------------------------------------
>
> (Updated July 12, 2016, 11:06 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1207
> https://issues.apache.org/jira/browse/LENS-1207
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes:
>
> 1. Make password optional in login
> 2. Add db as login parameter, just like java/python clients
> 3. By default only show base cubes. Can be configured to show all.
> 4. Modified start/stop scripts so that start is `npm start` and stop is `npm stop`
> 5. Lens server url and ui port is configurable by `.npmrc` now.
> 6. URLs changed. Now db is not part of the url, it's a session property, and is also cached in the client state
> 7. Reduced width of sidebar and increased width of main content
> 8. Corrected content in cube schema view. Now it shows joinchains and expressions too. Also, changed columns being displayed in measure and dimtable list.
> 9. Some bugfixes in error json parsing.
>
>
> Diffs
> -----
>
> lens-ui/app/actions/LoginActions.js 3cb39d0ce4b4de3bb8b1075658f54d4f29798162
> lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
> lens-ui/app/adapters/AuthenticationAdapter.js 15c196b7f0dcbed426b1af0973ba6c4cc088ad9c
> lens-ui/app/app.js 07d9acf2872590b971f5b66e07e35834bba42ec0
> lens-ui/app/components/AdhocQueryComponent.js aae823c93210f006118ae61a438ebd35fc0db8c4
> lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
> lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
> lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
> lens-ui/app/components/LoginComponent.js 23b3bb94eebdc7c1da0e5b0302b2e0402d5621b1
> lens-ui/app/components/QueryBoxComponent.js 30eb643c0faa24ac869741c26f4a60247ed6a865
> lens-ui/app/components/TableTreeComponent.js 9a8351e763bf2849e35ba5c9dc7b63ec4d7528ff
> lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
> lens-ui/app/stores/DatabaseStore.js a18e98657aad287e4aeeba7c283d44f2665b2792
> lens-ui/app/stores/UserStore.js 1d7e5d4710df01303211f219cf949c00515276a5
> lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
> lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
> lens-ui/package.json 0ed3db182c59d9744610a01ce8fc927161dda499
> lens-ui/server.js c8920f381df477a42ee4147fd98c6cde8b3ed209
>
> Diff: https://reviews.apache.org/r/49374/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/
-----------------------------------------------------------
(Updated July 12, 2016, 4:36 p.m.)
Review request for lens.
Bugs: LENS-1207
https://issues.apache.org/jira/browse/LENS-1207
Repository: lens
Description (updated)
-------
Changes:
1. Make password optional in login
2. Add db as login parameter, just like java/python clients
3. By default only show base cubes. Can be configured to show all.
4. Modified start/stop scripts so that start is `npm start` and stop is `npm stop`
5. Lens server url and ui port is configurable by `.npmrc` now.
6. URLs changed. Now db is not part of the url, it's a session property, and is also cached in the client state
7. Reduced width of sidebar and increased width of main content
8. Corrected content in cube schema view. Now it shows joinchains and expressions too. Also, changed columns being displayed in measure and dimtable list.
9. Some bugfixes in error json parsing.
Diffs
-----
lens-ui/app/actions/LoginActions.js 3cb39d0ce4b4de3bb8b1075658f54d4f29798162
lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
lens-ui/app/adapters/AuthenticationAdapter.js 15c196b7f0dcbed426b1af0973ba6c4cc088ad9c
lens-ui/app/app.js 07d9acf2872590b971f5b66e07e35834bba42ec0
lens-ui/app/components/AdhocQueryComponent.js aae823c93210f006118ae61a438ebd35fc0db8c4
lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
lens-ui/app/components/LoginComponent.js 23b3bb94eebdc7c1da0e5b0302b2e0402d5621b1
lens-ui/app/components/QueryBoxComponent.js 30eb643c0faa24ac869741c26f4a60247ed6a865
lens-ui/app/components/TableTreeComponent.js 9a8351e763bf2849e35ba5c9dc7b63ec4d7528ff
lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
lens-ui/app/stores/DatabaseStore.js a18e98657aad287e4aeeba7c283d44f2665b2792
lens-ui/app/stores/UserStore.js 1d7e5d4710df01303211f219cf949c00515276a5
lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
lens-ui/package.json 0ed3db182c59d9744610a01ce8fc927161dda499
lens-ui/server.js c8920f381df477a42ee4147fd98c6cde8b3ed209
Diff: https://reviews.apache.org/r/49374/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/
-----------------------------------------------------------
(Updated July 12, 2016, 4:30 p.m.)
Review request for lens.
Bugs: LENS-1207
https://issues.apache.org/jira/browse/LENS-1207
Repository: lens
Description
-------
Diffs (updated)
-----
lens-ui/app/actions/LoginActions.js 3cb39d0ce4b4de3bb8b1075658f54d4f29798162
lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
lens-ui/app/adapters/AuthenticationAdapter.js 15c196b7f0dcbed426b1af0973ba6c4cc088ad9c
lens-ui/app/app.js 07d9acf2872590b971f5b66e07e35834bba42ec0
lens-ui/app/components/AdhocQueryComponent.js aae823c93210f006118ae61a438ebd35fc0db8c4
lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
lens-ui/app/components/LoginComponent.js 23b3bb94eebdc7c1da0e5b0302b2e0402d5621b1
lens-ui/app/components/QueryBoxComponent.js 30eb643c0faa24ac869741c26f4a60247ed6a865
lens-ui/app/components/TableTreeComponent.js 9a8351e763bf2849e35ba5c9dc7b63ec4d7528ff
lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
lens-ui/app/stores/DatabaseStore.js a18e98657aad287e4aeeba7c283d44f2665b2792
lens-ui/app/stores/UserStore.js 1d7e5d4710df01303211f219cf949c00515276a5
lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
lens-ui/package.json 0ed3db182c59d9744610a01ce8fc927161dda499
lens-ui/server.js c8920f381df477a42ee4147fd98c6cde8b3ed209
Diff: https://reviews.apache.org/r/49374/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/
-----------------------------------------------------------
(Updated July 7, 2016, 1:31 p.m.)
Review request for lens.
Bugs: LENS-1207
https://issues.apache.org/jira/browse/LENS-1207
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/error/GenericExceptionMapper.java 9aa74ed0b9e1b7d03d2036e4c39497849bfed118
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java fdfd09cd3adc29113992063e249b18ec717ee20e
lens-ui/app/actions/LoginActions.js 3cb39d0ce4b4de3bb8b1075658f54d4f29798162
lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
lens-ui/app/adapters/AuthenticationAdapter.js 15c196b7f0dcbed426b1af0973ba6c4cc088ad9c
lens-ui/app/app.js 07d9acf2872590b971f5b66e07e35834bba42ec0
lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
lens-ui/app/components/LoginComponent.js 23b3bb94eebdc7c1da0e5b0302b2e0402d5621b1
lens-ui/app/components/QueryBoxComponent.js 30eb643c0faa24ac869741c26f4a60247ed6a865
lens-ui/app/components/TableTreeComponent.js 9a8351e763bf2849e35ba5c9dc7b63ec4d7528ff
lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
lens-ui/app/stores/DatabaseStore.js a18e98657aad287e4aeeba7c283d44f2665b2792
lens-ui/app/stores/UserStore.js 1d7e5d4710df01303211f219cf949c00515276a5
lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
lens-ui/package.json 0ed3db182c59d9744610a01ce8fc927161dda499
lens-ui/server.js c8920f381df477a42ee4147fd98c6cde8b3ed209
Diff: https://reviews.apache.org/r/49374/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On July 5, 2016, 11:54 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/error/GenericExceptionMapper.java, line 65
> > <https://reviews.apache.org/r/49374/diff/3/?file=1436312#file1436312line65>
> >
> > why is this change sitting here?
Removed
> On July 5, 2016, 11:54 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/config.json, line 4
> > <https://reviews.apache.org/r/49374/diff/3/?file=1436319#file1436319line4>
> >
> > Should we make it false, by default ?
Changed
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/#review140722
-----------------------------------------------------------
On July 12, 2016, 4:36 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49374/
> -----------------------------------------------------------
>
> (Updated July 12, 2016, 4:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1207
> https://issues.apache.org/jira/browse/LENS-1207
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes:
>
> 1. Make password optional in login
> 2. Add db as login parameter, just like java/python clients
> 3. By default only show base cubes. Can be configured to show all.
> 4. Modified start/stop scripts so that start is `npm start` and stop is `npm stop`
> 5. Lens server url and ui port is configurable by `.npmrc` now.
> 6. URLs changed. Now db is not part of the url, it's a session property, and is also cached in the client state
> 7. Reduced width of sidebar and increased width of main content
> 8. Corrected content in cube schema view. Now it shows joinchains and expressions too. Also, changed columns being displayed in measure and dimtable list.
> 9. Some bugfixes in error json parsing.
>
>
> Diffs
> -----
>
> lens-ui/app/actions/LoginActions.js 3cb39d0ce4b4de3bb8b1075658f54d4f29798162
> lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
> lens-ui/app/adapters/AuthenticationAdapter.js 15c196b7f0dcbed426b1af0973ba6c4cc088ad9c
> lens-ui/app/app.js 07d9acf2872590b971f5b66e07e35834bba42ec0
> lens-ui/app/components/AdhocQueryComponent.js aae823c93210f006118ae61a438ebd35fc0db8c4
> lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
> lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
> lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
> lens-ui/app/components/LoginComponent.js 23b3bb94eebdc7c1da0e5b0302b2e0402d5621b1
> lens-ui/app/components/QueryBoxComponent.js 30eb643c0faa24ac869741c26f4a60247ed6a865
> lens-ui/app/components/TableTreeComponent.js 9a8351e763bf2849e35ba5c9dc7b63ec4d7528ff
> lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
> lens-ui/app/stores/DatabaseStore.js a18e98657aad287e4aeeba7c283d44f2665b2792
> lens-ui/app/stores/UserStore.js 1d7e5d4710df01303211f219cf949c00515276a5
> lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
> lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
> lens-ui/package.json 0ed3db182c59d9744610a01ce8fc927161dda499
> lens-ui/server.js c8920f381df477a42ee4147fd98c6cde8b3ed209
>
> Diff: https://reviews.apache.org/r/49374/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/#review140722
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/error/GenericExceptionMapper.java (line 65)
<https://reviews.apache.org/r/49374/#comment206073>
why is this change sitting here?
lens-ui/config.json (line 4)
<https://reviews.apache.org/r/49374/#comment206074>
Should we make it false, by default ?
jira only mentions making native display optional. Please update with all changes being done.
- Amareshwari Sriramadasu
On July 4, 2016, 1:40 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49374/
> -----------------------------------------------------------
>
> (Updated July 4, 2016, 1:40 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1207
> https://issues.apache.org/jira/browse/LENS-1207
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/error/GenericExceptionMapper.java 9aa74ed0b9e1b7d03d2036e4c39497849bfed118
> lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
> lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
> lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
> lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
> lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
> lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
> lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
>
> Diff: https://reviews.apache.org/r/49374/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 49374: LENS-1207: Nativetable display should be
optional in lens ui
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49374/
-----------------------------------------------------------
(Updated July 4, 2016, 7:10 p.m.)
Review request for lens.
Bugs: LENS-1207
https://issues.apache.org/jira/browse/LENS-1207
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/error/GenericExceptionMapper.java 9aa74ed0b9e1b7d03d2036e4c39497849bfed118
lens-ui/app/adapters/AdhocQueryAdapter.js 9d4b416573c3eb2d5b70cc8e6a334038de071219
lens-ui/app/components/CubeSchemaComponent.js dbb4cbcfab6bab4818f4035514cdbff112afd4e5
lens-ui/app/components/CubeTreeComponent.js 702fa368541a54b7a1d37e11f0619751fd35234b
lens-ui/app/components/DatabaseComponent.js 15a4e46e38a2d32655f8e07a376c90dc4272482b
lens-ui/app/stores/CubeStore.js 4441e54ed67ccca9996819d2e314b2520e3727fb
lens-ui/app/utils/ErrorParser.js 8bd0d90a1f6cfa756def1e88ceab013a863dfe2c
lens-ui/config.json bebc7e5d423ec9c20114965a623192d4cad85f2f
Diff: https://reviews.apache.org/r/49374/diff/
Testing
-------
Thanks,
Rajat Khandelwal