You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/13 19:04:14 UTC

[GitHub] [camel-kamelets] lburgazzoli opened a new pull request #423: ci: tweak test workflow

lburgazzoli opened a new pull request #423:
URL: https://github.com/apache/camel-kamelets/pull/423


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] oscerd commented on pull request #423: ci: tweak test workflow

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #423:
URL: https://github.com/apache/camel-kamelets/pull/423#issuecomment-911662792


   Do we want to merge this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] lburgazzoli commented on pull request #423: ci: tweak test workflow

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #423:
URL: https://github.com/apache/camel-kamelets/pull/423#issuecomment-911672345


   don't think it is needed anymore
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] lburgazzoli commented on a change in pull request #423: ci: tweak test workflow

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #423:
URL: https://github.com/apache/camel-kamelets/pull/423#discussion_r670210774



##########
File path: .github/workflows/test.yaml
##########
@@ -87,8 +112,16 @@ jobs:
         echo "Configuring Yaks"
         yaks install
 
+    - name: Run Tests
+      run: |
+        # Configure install options
+        export KAMEL_INSTALL_BUILD_PUBLISH_STRATEGY=Spectrum
+        export KAMEL_INSTALL_REGISTRY=$KIND_REGISTRY
+        export KAMEL_INSTALL_REGISTRY_INSECURE=true
+
         echo "Running tests"
-        yaks test ./test
+        yaks run --logs --wait ./test

Review comment:
       yeah, it was an attempt to see if for some reason the cli was not working as expected
   btw, yaks test does not seems to exists as a sub-command is that correct ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] lburgazzoli commented on pull request #423: ci: tweak test workflow

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #423:
URL: https://github.com/apache/camel-kamelets/pull/423#issuecomment-881558015


   @nicolaferraro don't know if it is worth merging it, it was mainly an attempt to understand why it was not working.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] lburgazzoli closed pull request #423: ci: tweak test workflow

Posted by GitBox <gi...@apache.org>.
lburgazzoli closed pull request #423:
URL: https://github.com/apache/camel-kamelets/pull/423


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] nicolaferraro commented on a change in pull request #423: ci: tweak test workflow

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on a change in pull request #423:
URL: https://github.com/apache/camel-kamelets/pull/423#discussion_r670208468



##########
File path: .github/workflows/test.yaml
##########
@@ -87,8 +112,16 @@ jobs:
         echo "Configuring Yaks"
         yaks install
 
+    - name: Run Tests
+      run: |
+        # Configure install options
+        export KAMEL_INSTALL_BUILD_PUBLISH_STRATEGY=Spectrum
+        export KAMEL_INSTALL_REGISTRY=$KIND_REGISTRY
+        export KAMEL_INSTALL_REGISTRY_INSECURE=true
+
         echo "Running tests"
-        yaks test ./test
+        yaks run --logs --wait ./test

Review comment:
       Does not seem to wait...
   ```suggestion
           yaks test ./test
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org