You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CAICAIIs (via GitHub)" <gi...@apache.org> on 2025/07/23 09:50:55 UTC
[PR] fix(samples): ensure MetricsConfig is present for metrics-related samples [dubbo-samples]
CAICAIIs opened a new pull request, #1238:
URL: https://github.com/apache/dubbo-samples/pull/1238
## Problem Description
Fix the issue where metrics logs were not being printed normally in Dubbo samples due to missing or incomplete MetricsConfig. Previously, samples would output `[DUBBO] The MetricsConfig not exist, will not export metrics service.`
## Changes Made
- Add or fix MetricsConfig configuration in metrics-spring-boot and metrics-prometheus samples
- Ensure metrics service is properly enabled and protocol is set where required
- Only modify samples that previously output the MetricsConfig missing warning
## Files Modified
- `4-governance/dubbo-samples-metrics-spring-boot/src/main/resources/application.yaml`
- `4-governance/dubbo-samples-metrics-prometheus/dubbo-samples-metrics-prometheus-provider/src/main/resources/dubbo-demo-provider.xml`
- `4-governance/dubbo-samples-metrics-prometheus/dubbo-samples-metrics-prometheus-consumer/src/main/resources/dubbo-demo-consumer.xml`
## Technical Details
- Added `enable: true` to Dubbo metrics configuration in Spring Boot sample
- Added `enabled="true"` attribute to `<dubbo:metrics ...>` in XML-based prometheus samples
- Followed Dubbo community coding and commit standards
## Related Issue
Related to apache/dubbo#15473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(samples): ensure MetricsConfig is present for metrics-related samples [dubbo-samples]
Posted by "zrlw (via GitHub)" <gi...@apache.org>.
zrlw merged PR #1238:
URL: https://github.com/apache/dubbo-samples/pull/1238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org