[GitHub] [beam] aaltay commented on a change in pull request #11408: [BEAM-9744] Remove --region option from SQL tests.

[GitBox <gi...@apache.org>]

aaltay commented on a change in pull request #11408: [BEAM-9744] Remove --region option from SQL tests.
URL: https://github.com/apache/beam/pull/11408#discussion_r407745861
 
 

 ##########
 File path: sdks/java/extensions/sql/build.gradle
 ##########
 @@ -149,15 +149,13 @@ task runPojoExample(type: JavaExec) {
 task integrationTest(type: Test) {
   group = "Verification"
   def gcpProject = project.findProperty('gcpProject') ?: 'apache-beam-testing'
-  def gcpRegion = project.findProperty('gcpRegion') ?: 'us-central1'
   def gcsTempRoot = project.findProperty('gcsTempRoot') ?: 'gs://temp-storage-for-end-to-end-tests/'
 
   // Disable Gradle cache (it should not be used because the IT's won't run).
   outputs.upToDateWhen { false }
 
   def pipelineOptions = [
           "--project=${gcpProject}",
 
 Review comment:
   If they don't run on Dataflow, what is project and other gcp flags are used for?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services