You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/19 22:27:05 UTC

[GitHub] srkukarni opened a new pull request #2813: Removed Validation Annotations and do manual Validation

srkukarni opened a new pull request #2813: Removed Validation Annotations and do manual Validation
URL: https://github.com/apache/pulsar/pull/2813
 
 
   ### Motivation
   Actual validation involving function/serde/schema definitions have to link with the defn of the appropriate classes. Thus having annotations around the various config classes like(functionconfig/sourceconfig/sinkconfig) means that we will enter into a dependency mess where pulsar-admin will start depending on functions, etc. 
   Thus in order to break this vicious cycle, this pr removes the validation annotation classes and does the validation explictly in various helper classes. This will now make the config classes pure pojo which can now be moved to pulsar-common.
   ### Modifications
   
   Describe the modifications you've done.
   
   ### Result
   
   After your change, what will change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services