You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/12 02:10:17 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
yamt opened a new pull request #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550
The remaining errors:
Mixed case identifier found
I didn't fix them because they were on ROM symbols,
which are not supposed to obey NuttX's coding style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-597972420
my suggestion is to hardcode whitelists in nxstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus edited a comment on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
johannes-nivus edited a comment on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-598844436
>
>
> I like the idea of white lists.
What about a comment section that can signal allowed variable names that would otherwise violate coding standard?
That would keep it self containing.
Edit for clarification: I mean a comment section inside the file under test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-598826284
@yamt I like the idea of white lists. @Ouss4 but I agree that a supset of all while listed variables for all architectures is not practical or maintainable. How about (1) an internal whilelist inside of nxstyle that will accept common mixed case sysmbols, and (1) and optional command line argument to refer to a file of additional whitlisted names?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-598551794
@Ouss4
right. do you have any alternative suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-598981971
There is nothing we can do to the nxstyle complaints at this point.
I suggest we go ahead and merge this. The changes are only cosmtics it doesn't need to be rebased to kick the CI off.
Let's move the white list discussion to a separate "issue".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-598125291
There already are some hard coded mixed case identifiers, for system calls for instance.
But those are, standardized and used throughout the code base.
In this case, the identifiers are only Xtensa related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-598844436
>
>
> I like the idea of white lists.
What about a comment section that can signal allowed variable names that would otherwise violate coding standard?
That would keep it self containing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-598797405
@johannes-nivus i believe that file is from esp-idf. not "ours".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-598759075
@yamt
Perhaps have a look at the ld file (boards/xtensa/esp32/esp32-core/scripts/esp32_rom.ld) and change the symbol names to lowercase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-598986790
> I suggest we go ahead and merge this.
I agree. The only downside is that the nxstyle checks have blocked the other, more important tests. I believe that this is a PR to fix this, but is has not been merged.
I will go ahead and do the merge so that this does not linger as an Open PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #550:
arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-599137589
Please see #569 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services