You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/23 08:38:28 UTC
[GitHub] [apisix-dashboard] gxthrj opened a new pull request #1108: chore: mv main.go to cmd
gxthrj opened a new pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108
Fix #721
Fix #731
Added `cmd` path and move the `main.go` to `./api/cmd/manager`.
Ref to [golang-standards-project-layout](https://github.com/golang-standards/project-layout)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751247756
@gxthrj do we need to update docs for changes ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750795526
CI failed. @gxthrj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report
> Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=desc) (030ef8b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/78b4031d6899be672fcb41b29fcb40f9f898509b?el=desc) (78b4031) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 41.86% 41.86%
=======================================
Files 29 29
Lines 1825 1825
=======================================
Hits 764 764
Misses 953 953
Partials 108 108
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `60.46% <ø> (ø)` | |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `88.09% <ø> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.12% <ø> (ø)` | |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <ø> (ø)` | |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <ø> (ø)` | |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `0.00% <ø> (ø)` | |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | `86.95% <ø> (ø)` | |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <ø> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=footer). Last update [78b4031...030ef8b](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750802448
> CI failed. @gxthrj
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report
> Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=desc) (cee56d2) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/78b4031d6899be672fcb41b29fcb40f9f898509b?el=desc) (78b4031) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 41.86% 41.86%
=======================================
Files 29 29
Lines 1825 1825
=======================================
Hits 764 764
Misses 953 953
Partials 108 108
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `60.46% <ø> (ø)` | |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `88.09% <ø> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.12% <ø> (ø)` | |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <ø> (ø)` | |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <ø> (ø)` | |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `0.00% <ø> (ø)` | |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | `86.95% <ø> (ø)` | |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <ø> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=footer). Last update [78b4031...cee56d2](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#discussion_r548865291
##########
File path: api/internal/handler/route/route.go
##########
@@ -30,15 +30,15 @@ import (
"github.com/shiningrush/droplet/data"
"github.com/shiningrush/droplet/wrapper"
wgin "github.com/shiningrush/droplet/wrapper/gin"
- "github.com/yuin/gopher-lua"
- "github.com/apisix/manager-api/conf"
+ "github.com/apisix/manager-api/internal/conf"
"github.com/apisix/manager-api/internal/core/entity"
"github.com/apisix/manager-api/internal/core/store"
"github.com/apisix/manager-api/internal/handler"
+ "github.com/apisix/manager-api/internal/log"
"github.com/apisix/manager-api/internal/utils"
"github.com/apisix/manager-api/internal/utils/consts"
- "github.com/apisix/manager-api/log"
+ lua "github.com/yuin/gopher-lua"
Review comment:
Done
##########
File path: api/internal/filter/recover.go
##########
@@ -24,7 +24,7 @@ import (
"runtime"
"time"
- "github.com/apisix/manager-api/log"
+ "github.com/apisix/manager-api/internal/log"
Review comment:
Done
##########
File path: api/internal/filter/authentication.go
##########
@@ -20,11 +20,11 @@ import (
"net/http"
"strings"
- "github.com/dgrijalva/jwt-go"
"github.com/gin-gonic/gin"
- "github.com/apisix/manager-api/conf"
- "github.com/apisix/manager-api/log"
+ "github.com/apisix/manager-api/internal/conf"
+ "github.com/apisix/manager-api/internal/log"
+ jwt "github.com/dgrijalva/jwt-go"
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751132236
should we move 'log' and 'conf' into 'internal' too？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#discussion_r548868619
##########
File path: api/internal/handler/route/route.go
##########
@@ -29,16 +29,16 @@ import (
"github.com/shiningrush/droplet"
"github.com/shiningrush/droplet/data"
"github.com/shiningrush/droplet/wrapper"
- wgin "github.com/shiningrush/droplet/wrapper/gin"
"github.com/yuin/gopher-lua"
-
- "github.com/apisix/manager-api/conf"
+ wgin "github.com/shiningrush/droplet/wrapper/gin"
+ "github.com/apisix/manager-api/internal/conf"
"github.com/apisix/manager-api/internal/core/entity"
"github.com/apisix/manager-api/internal/core/store"
"github.com/apisix/manager-api/internal/handler"
+ "github.com/apisix/manager-api/internal/log"
"github.com/apisix/manager-api/internal/utils"
"github.com/apisix/manager-api/internal/utils/consts"
- "github.com/apisix/manager-api/log"
+
Review comment:
Redundant line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#discussion_r548869960
##########
File path: api/internal/handler/route/route.go
##########
@@ -29,16 +29,16 @@ import (
"github.com/shiningrush/droplet"
"github.com/shiningrush/droplet/data"
"github.com/shiningrush/droplet/wrapper"
- wgin "github.com/shiningrush/droplet/wrapper/gin"
"github.com/yuin/gopher-lua"
-
- "github.com/apisix/manager-api/conf"
+ wgin "github.com/shiningrush/droplet/wrapper/gin"
+ "github.com/apisix/manager-api/internal/conf"
"github.com/apisix/manager-api/internal/core/entity"
"github.com/apisix/manager-api/internal/core/store"
"github.com/apisix/manager-api/internal/handler"
+ "github.com/apisix/manager-api/internal/log"
"github.com/apisix/manager-api/internal/utils"
"github.com/apisix/manager-api/internal/utils/consts"
- "github.com/apisix/manager-api/log"
+
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751173797
> should we move 'log' and 'conf' into 'internal' too？
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report
> Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=desc) (16b2aab) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0e6e2805362a8dc9b83f56f53be17f12a8ddbacf?el=desc) (0e6e280) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
- Coverage 41.94% 41.88% -0.06%
==========================================
Files 29 29
Lines 1824 1824
==========================================
- Hits 765 764 -1
- Misses 951 952 +1
Partials 108 108
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `60.46% <ø> (ø)` | |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `88.09% <ø> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <ø> (-0.65%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <ø> (ø)` | |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <ø> (ø)` | |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `0.00% <ø> (ø)` | |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | `86.95% <ø> (ø)` | |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <ø> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=footer). Last update [0e6e280...16b2aab](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report
> Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=desc) (9685988) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/266605229184a501a7bbf40e19e67df68d3367f3?el=desc) (2666052) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 41.94% 41.94%
=======================================
Files 29 29
Lines 1824 1824
=======================================
Hits 765 765
Misses 951 951
Partials 108 108
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `60.46% <ø> (ø)` | |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `88.09% <ø> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <ø> (ø)` | |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <ø> (ø)` | |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <ø> (ø)` | |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `0.00% <ø> (ø)` | |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | `86.95% <ø> (ø)` | |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <ø> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=footer). Last update [2666052...9685988](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report
> Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=desc) (b711a57) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/46bf1ef9cfe4f4c659752176424151bb4fc4952f?el=desc) (46bf1ef) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 41.06% 41.06%
=======================================
Files 28 28
Lines 1773 1773
=======================================
Hits 728 728
Misses 939 939
Partials 106 106
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=footer). Last update [46bf1ef...b711a57](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751252597
> @gxthrj do we need to update docs for changes ?
The original document refers to `make build` directly when building, so there is no need to update docs.
But we can add a supplementary notes on directory structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report
> Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=desc) (93eb109) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0e6e2805362a8dc9b83f56f53be17f12a8ddbacf?el=desc) (0e6e280) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 41.94% 41.94%
=======================================
Files 29 29
Lines 1824 1824
=======================================
Hits 765 765
Misses 951 951
Partials 108 108
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=footer). Last update [0e6e280...93eb109](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751254496
cc @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#discussion_r548810935
##########
File path: api/internal/filter/authentication.go
##########
@@ -20,11 +20,11 @@ import (
"net/http"
"strings"
- "github.com/dgrijalva/jwt-go"
"github.com/gin-gonic/gin"
- "github.com/apisix/manager-api/conf"
- "github.com/apisix/manager-api/log"
+ "github.com/apisix/manager-api/internal/conf"
+ "github.com/apisix/manager-api/internal/log"
+ jwt "github.com/dgrijalva/jwt-go"
Review comment:
I think we should classify the import package.
See https://github.com/uber-go/guide/blob/master/style.md#import-group-ordering
##########
File path: api/internal/filter/recover.go
##########
@@ -24,7 +24,7 @@ import (
"runtime"
"time"
- "github.com/apisix/manager-api/log"
+ "github.com/apisix/manager-api/internal/log"
Review comment:
Ditto.
##########
File path: api/internal/handler/route/route.go
##########
@@ -30,15 +30,15 @@ import (
"github.com/shiningrush/droplet/data"
"github.com/shiningrush/droplet/wrapper"
wgin "github.com/shiningrush/droplet/wrapper/gin"
- "github.com/yuin/gopher-lua"
- "github.com/apisix/manager-api/conf"
+ "github.com/apisix/manager-api/internal/conf"
"github.com/apisix/manager-api/internal/core/entity"
"github.com/apisix/manager-api/internal/core/store"
"github.com/apisix/manager-api/internal/handler"
+ "github.com/apisix/manager-api/internal/log"
"github.com/apisix/manager-api/internal/utils"
"github.com/apisix/manager-api/internal/utils/consts"
- "github.com/apisix/manager-api/log"
+ lua "github.com/yuin/gopher-lua"
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751214595
conflicts ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: adjust directory structure of api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report
> Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=desc) (4eef266) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/78b4031d6899be672fcb41b29fcb40f9f898509b?el=desc) (78b4031) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
- Coverage 41.86% 41.80% -0.06%
==========================================
Files 29 29
Lines 1825 1825
==========================================
- Hits 764 763 -1
- Misses 953 954 +1
Partials 108 108
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `60.46% <ø> (ø)` | |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `88.09% <ø> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.50% <ø> (-0.63%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <ø> (ø)` | |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <ø> (ø)` | |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `0.00% <ø> (ø)` | |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | `86.95% <ø> (ø)` | |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <ø> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=footer). Last update [78b4031...4eef266](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report
> Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=desc) (7a08ae8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/46bf1ef9cfe4f4c659752176424151bb4fc4952f?el=desc) (46bf1ef) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 41.06% 41.06%
=======================================
Files 28 28
Lines 1773 1773
=======================================
Hits 728 728
Misses 939 939
Partials 106 106
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=footer). Last update [46bf1ef...7a08ae8](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: mv main.go to cmd
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1108:
URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report
> Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=desc) (a4699f7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/266605229184a501a7bbf40e19e67df68d3367f3?el=desc) (2666052) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 41.94% 41.94%
=======================================
Files 29 29
Lines 1824 1824
=======================================
Hits 765 765
Misses 951 951
Partials 108 108
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `60.46% <ø> (ø)` | |
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `88.09% <ø> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <ø> (ø)` | |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <ø> (ø)` | |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <ø> (ø)` | |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `0.00% <ø> (ø)` | |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | `86.95% <ø> (ø)` | |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <ø> (ø)` | |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <ø> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1108/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=footer). Last update [2666052...a4699f7](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org