You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2008/07/14 15:08:49 UTC
svn commit: r676577 -
/maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java
Author: vsiveton
Date: Mon Jul 14 06:08:49 2008
New Revision: 676577
URL: http://svn.apache.org/viewvc?rev=676577&view=rev
Log:
o minor improvements
Modified:
maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java
Modified: maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java?rev=676577&r1=676576&r2=676577&view=diff
==============================================================================
--- maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java (original)
+++ maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java Mon Jul 14 06:08:49 2008
@@ -90,10 +90,8 @@
/** {@inheritDoc} */
public void executeReport( Locale locale )
{
- PluginManagementRenderer r = new PluginManagementRenderer( getSink(), locale, i18n, project
+ PluginManagementRenderer r = new PluginManagementRenderer( getLog(), getSink(), locale, i18n, project
.getPluginManagement().getPlugins(), project, mavenProjectBuilder, artifactFactory, localRepository );
-
- r.setLog( getLog() );
r.render();
}
@@ -122,6 +120,8 @@
protected static class PluginManagementRenderer
extends AbstractMavenReportRenderer
{
+ private final Log log;
+
private final List pluginManagement;
private final Locale locale;
@@ -136,9 +136,8 @@
private final ArtifactRepository localRepository;
- private Log log;
-
/**
+ * @param log
* @param sink
* @param locale
* @param i18n
@@ -148,12 +147,14 @@
* @param artifactFactory
* @param localRepository
*/
- public PluginManagementRenderer( Sink sink, Locale locale, I18N i18n, List plugins, MavenProject project,
+ public PluginManagementRenderer( Log log, Sink sink, Locale locale, I18N i18n, List plugins, MavenProject project,
MavenProjectBuilder mavenProjectBuilder, ArtifactFactory artifactFactory,
ArtifactRepository localRepository )
{
super( sink );
+ this.log = log;
+
this.locale = locale;
this.pluginManagement = plugins;
@@ -169,10 +170,6 @@
this.localRepository = localRepository;
}
- public void setLog( Log log )
- {
- this.log = log;
- }
/** {@inheritDoc} */
public String getTitle()
@@ -245,6 +242,7 @@
private String[] getPluginTableHeader()
{
+ // reused key...
String groupId = getReportString( "report.dependencyManagement.column.groupId" );
String artifactId = getReportString( "report.dependencyManagement.column.artifactId" );
String version = getReportString( "report.dependencyManagement.column.version" );