[GitHub] [hive] kasakrisz commented on a change in pull request #2060: HIVE-24865: Implement Respect/Ignore Nulls in first/last_value

[GitBox <gi...@apache.org>]

kasakrisz commented on a change in pull request #2060:
URL: https://github.com/apache/hive/pull/2060#discussion_r592059837



##########
File path: parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexerParent.g
##########
@@ -376,6 +376,8 @@ KW_PKFK_JOIN: 'PKFK_JOIN';
 KW_LEADING: 'LEADING';
 KW_TRAILING: 'TRAILING';
 KW_TRIM: 'TRIM';
+KW_IGNORE: 'IGNORE';

Review comment:
       These are non-reserved keywords: added `Respect` to the list, `Ignore` was already there but it was not defined in the lexer before this patch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org