You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mb...@apache.org on 2005/10/19 11:57:42 UTC

svn commit: r326516 - in /myfaces/impl/trunk/src/java/org/apache/myfaces: application/NavigationHandlerImpl.java context/servlet/ServletExternalContextImpl.java

Author: mbr
Date: Wed Oct 19 02:57:36 2005
New Revision: 326516

URL: http://svn.apache.org/viewcvs?rev=326516&view=rev
Log:
fix for MYFACES-718, thanks to Nico Krijnen

Modified:
    myfaces/impl/trunk/src/java/org/apache/myfaces/application/NavigationHandlerImpl.java
    myfaces/impl/trunk/src/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java

Modified: myfaces/impl/trunk/src/java/org/apache/myfaces/application/NavigationHandlerImpl.java
URL: http://svn.apache.org/viewcvs/myfaces/impl/trunk/src/java/org/apache/myfaces/application/NavigationHandlerImpl.java?rev=326516&r1=326515&r2=326516&view=diff
==============================================================================
--- myfaces/impl/trunk/src/java/org/apache/myfaces/application/NavigationHandlerImpl.java (original)
+++ myfaces/impl/trunk/src/java/org/apache/myfaces/application/NavigationHandlerImpl.java Wed Oct 19 02:57:36 2005
@@ -135,7 +135,6 @@
                 {
                     throw new FacesException(e.getMessage(), e);
                 }
-                facesContext.responseComplete();
             }
             else
             {

Modified: myfaces/impl/trunk/src/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
URL: http://svn.apache.org/viewcvs/myfaces/impl/trunk/src/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java?rev=326516&r1=326515&r2=326516&view=diff
==============================================================================
--- myfaces/impl/trunk/src/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java (original)
+++ myfaces/impl/trunk/src/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java Wed Oct 19 02:57:36 2005
@@ -20,6 +20,7 @@
 import javax.faces.FacesException;
 import javax.faces.application.ViewHandler;
 import javax.faces.context.ExternalContext;
+import javax.faces.context.FacesContext;
 import javax.servlet.*;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
@@ -487,6 +488,7 @@
         if (_servletResponse instanceof HttpServletResponse)
         {
             ((HttpServletResponse)_servletResponse).sendRedirect(url);
+            FacesContext.getCurrentInstance().responseComplete();            
         }
         else
         {