[GitHub] [systemds] Baunsgaard commented on a change in pull request #1489: [SYSTEMDS-3167] Alternative Implementations of Eigen Decomposition

[GitBox <gi...@apache.org>]

Baunsgaard commented on a change in pull request #1489:
URL: https://github.com/apache/systemds/pull/1489#discussion_r775947098



##########
File path: src/main/java/org/apache/sysds/runtime/matrix/data/LibCommonsMath.java
##########
@@ -76,11 +79,17 @@ else if (opcode.equals("cholesky"))
 	public static MatrixBlock[] multiReturnOperations(MatrixBlock in, String opcode) {
 		if(opcode.equals("qr"))
 			return computeQR(in);
+		else if (opcode.equals("qr2"))
+			return computeQR2(in);
 		else if (opcode.equals("lu"))
 			return computeLU(in);
 		else if (opcode.equals("eigen"))
 			return computeEigen(in);
-		else if ( opcode.equals("svd"))
+		else if (opcode.equals("eigen_lanczos"))
+			return computeEigenLanczos(in);
+		else if (opcode.equals("eigen_qr"))
+			return computeEigenQR(in);
+		else if (opcode.equals("svd"))

Review comment:
       for now no, these operations are only available sideways calling directly into LibCommonsMath




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org