You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Henri Yandell <fl...@gmail.com> on 2007/01/31 00:24:08 UTC
[VOTE] Lang 2.3 RC1
Next up - Lang 2.3.
Here's the release candidate:
http://people.apache.org/~bayard/commons-lang/commons-lang-2.3-rc1/
Clirr, Jardiff + Site included.
[ ] +1
[ ] -1
Vote to close on Monday if it gets that far.
There is an open issue in JIRA currently:
http://issues.apache.org/jira/browse/LANG-69
I'm keeping it open for a little bit longer in case anyone has any
opinions on my fix to this.
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Henri Yandell <fl...@gmail.com>.
On 1/31/07, Oliver Heger <ol...@oliver-heger.de> wrote:
> +1
Thanks :) I think I sent the email too soon after IO, people are release-tired.
> Two (very) minor nits:
> - There are some pmd warnings.
I've fixed the unused imports one. The others don't seem like problems
to me, possibly need to figure out how to turn off the empty-catch
warning so it stops spamming things.
> - The binary distro contains only the API docs. AFAIK most other
> components ship here the complete site.
Lame idea imo - or at least good idea (have documentation), lame
implementation (throw website in). It is tempting to pull the
user-guide into the front page of the javadoc, or to make proper
offline docs.
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Oliver Heger <ol...@oliver-heger.de>.
+1
Two (very) minor nits:
- There are some pmd warnings.
- The binary distro contains only the API docs. AFAIK most other
components ship here the complete site.
Oliver
Henri Yandell wrote:
> Next up - Lang 2.3.
>
> Here's the release candidate:
>
> http://people.apache.org/~bayard/commons-lang/commons-lang-2.3-rc1/
>
> Clirr, Jardiff + Site included.
>
> [ ] +1
> [ ] -1
>
> Vote to close on Monday if it gets that far.
>
> There is an open issue in JIRA currently:
>
> http://issues.apache.org/jira/browse/LANG-69
>
> I'm keeping it open for a little bit longer in case anyone has any
> opinions on my fix to this.
>
> Hen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Stephen Colebourne <sc...@btopenworld.com>.
Rahul Akolkar wrote:
> On 2/2/07, Niall Pemberton <ni...@gmail.com> wrote:
>> On 2/1/07, Henri Yandell <fl...@gmail.com> wrote:
>> > What do people think - update PROPOSALs or delete them?
>>
>> Neither - leave it unchanged. It is historical and I think it is
>> obvious it is, many (most?) components have them and I've never seen
>> it raised as a cause for confusion.
>>
> <snap/>
>
> Archival is good, I read proposals. But from trunk. One way to avoid
> potential confusion is to not make it part of the distros, if indeed
> it is added there.
I think the proposal should no longer be part of the website or distro,
but left unchanged in SVN. There may be a case for an updated scope doc
on the website (ie. a new xdoc).
Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Rahul Akolkar <ra...@gmail.com>.
On 2/2/07, Niall Pemberton <ni...@gmail.com> wrote:
> On 2/1/07, Henri Yandell <fl...@gmail.com> wrote:
<snip/>
> >
> > What do people think - update PROPOSALs or delete them?
>
> Neither - leave it unchanged. It is historical and I think it is
> obvious it is, many (most?) components have them and I've never seen
> it raised as a cause for confusion.
>
<snap/>
Archival is good, I read proposals. But from trunk. One way to avoid
potential confusion is to not make it part of the distros, if indeed
it is added there.
-Rahul
> Niall
>
> > Hen
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Niall Pemberton <ni...@gmail.com>.
On 2/1/07, Henri Yandell <fl...@gmail.com> wrote:
> Might have to stop the vote anyway as it looks like the refactoring to
> Entities.java undid an optimisation issue.
>
> On 2/1/07, Jörg Schaible <jo...@gmx.de> wrote:
> > Correction: Tests did *not* run:
> > Testcase: testLang312(org.apache.commons.lang.time.DateFormatUtilsTest):
> > FAILED
> > It's the part of the fixture that tests the JDK ... maybe this should not be
> > asserted and better be replaced by a simple sysout? In the end you cannot
> > know what was changed/fixed by Sun in which JDK version (and if the
> > assumption is valid for other JDKs) and it does not make sense to rely our
> > tests on such a behavior.
>
> How depressing. Yeah I think the best thing to do here is to test and
> then print a WARNING rather than having JUnit fail.
>
> > Jörg Schaible wrote:
> >
> > > +1
> > >
> > > Rebuild from the src package with Sun JDK 5 under Linux.
> > >
> > > Minor: I understand that the proposal is a historical document, but it
> > > claims that c-lang is build on top of JDK 1.2 ... that might be confusing.
>
> What do people think - update PROPOSALs or delete them?
Neither - leave it unchanged. It is historical and I think it is
obvious it is, many (most?) components have them and I've never seen
it raised as a cause for confusion.
Niall
> Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Henri Yandell <fl...@gmail.com>.
Might have to stop the vote anyway as it looks like the refactoring to
Entities.java undid an optimisation issue.
On 2/1/07, Jörg Schaible <jo...@gmx.de> wrote:
> Correction: Tests did *not* run:
> Testcase: testLang312(org.apache.commons.lang.time.DateFormatUtilsTest):
> FAILED
> It's the part of the fixture that tests the JDK ... maybe this should not be
> asserted and better be replaced by a simple sysout? In the end you cannot
> know what was changed/fixed by Sun in which JDK version (and if the
> assumption is valid for other JDKs) and it does not make sense to rely our
> tests on such a behavior.
How depressing. Yeah I think the best thing to do here is to test and
then print a WARNING rather than having JUnit fail.
> Jörg Schaible wrote:
>
> > +1
> >
> > Rebuild from the src package with Sun JDK 5 under Linux.
> >
> > Minor: I understand that the proposal is a historical document, but it
> > claims that c-lang is build on top of JDK 1.2 ... that might be confusing.
What do people think - update PROPOSALs or delete them?
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Jörg Schaible <jo...@gmx.de>.
Correction: Tests did *not* run:
========= %< ============
$ ant
...
[junit] Tests run: 224, Failures: 0, Errors: 0, Time elapsed: 0,11 sec
test.time:
[junit] Running org.apache.commons.lang.time.TimeTestSuite
[junit] Tests run: 61, Failures: 1, Errors: 0, Time elapsed: 8,094 sec
[junit] Test org.apache.commons.lang.time.TimeTestSuite FAILED
test:
[echo] Running tests ...
BUILD SUCCESSFUL
========= %< ============
Building with M1 fails therefore. Test report:
========= %< ============
Testsuite: org.apache.commons.lang.time.TimeTestSuite
Tests run: 61, Failures: 1, Errors: 0, Time elapsed: 8,938 sec
Testcase: testLang312(org.apache.commons.lang.time.DateFormatUtilsTest):
FAILED
expected:<...9...> but was:<...8...>
junit.framework.ComparisonFailure: expected:<...9...> but was:<...8...>
at org.apache.commons.lang.time.DateFormatUtilsTest.testLang31
(DateFormatUtilsTest.java:230)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
========= %< ============
It's the part of the fixture that tests the JDK ... maybe this should not be
asserted and better be replaced by a simple sysout? In the end you cannot
know what was changed/fixed by Sun in which JDK version (and if the
assumption is valid for other JDKs) and it does not make sense to rely our
tests on such a behavior.
- Jörg
Jörg Schaible wrote:
> +1
>
> Rebuild from the src package with Sun JDK 5 under Linux.
>
> Minor: I understand that the proposal is a historical document, but it
> claims that c-lang is build on top of JDK 1.2 ... that might be confusing.
>
> - Jörg
>
>
> Henri Yandell wrote:
>
>> Next up - Lang 2.3.
>>
>> Here's the release candidate:
>>
>> http://people.apache.org/~bayard/commons-lang/commons-lang-2.3-rc1/
>>
>> Clirr, Jardiff + Site included.
>>
>> [ ] +1
>> [ ] -1
>>
>> Vote to close on Monday if it gets that far.
>>
>> There is an open issue in JIRA currently:
>>
>> http://issues.apache.org/jira/browse/LANG-69
>>
>> I'm keeping it open for a little bit longer in case anyone has any
>> opinions on my fix to this.
>>
>> Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Jörg Schaible <jo...@gmx.de>.
+1
Rebuild from the src package with Sun JDK 5 under Linux.
Minor: I understand that the proposal is a historical document, but it
claims that c-lang is build on top of JDK 1.2 ... that might be confusing.
- Jörg
Henri Yandell wrote:
> Next up - Lang 2.3.
>
> Here's the release candidate:
>
> http://people.apache.org/~bayard/commons-lang/commons-lang-2.3-rc1/
>
> Clirr, Jardiff + Site included.
>
> [ ] +1
> [ ] -1
>
> Vote to close on Monday if it gets that far.
>
> There is an open issue in JIRA currently:
>
> http://issues.apache.org/jira/browse/LANG-69
>
> I'm keeping it open for a little bit longer in case anyone has any
> opinions on my fix to this.
>
> Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Stephen Colebourne <sc...@btopenworld.com>.
+1
Although compared to [io] we probably should have a sources and javadoc
jar in the zips as well.
Stephen
Henri Yandell wrote:
> Next up - Lang 2.3.
>
> Here's the release candidate:
>
> http://people.apache.org/~bayard/commons-lang/commons-lang-2.3-rc1/
>
> Clirr, Jardiff + Site included.
>
> [ ] +1
> [ ] -1
>
> Vote to close on Monday if it gets that far.
>
> There is an open issue in JIRA currently:
>
> http://issues.apache.org/jira/browse/LANG-69
>
> I'm keeping it open for a little bit longer in case anyone has any
> opinions on my fix to this.
>
> Hen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Henri Yandell <fl...@gmail.com>.
Never! Zipped sites are the new thing.
Done. Sorry about that.
On 1/30/07, Stephen Colebourne <sc...@btopenworld.com> wrote:
> Any chance you could unzip the site?
> Stephen
>
> Henri Yandell wrote:
> > Next up - Lang 2.3.
> >
> > Here's the release candidate:
> >
> > http://people.apache.org/~bayard/commons-lang/commons-lang-2.3-rc1/
> >
> > Clirr, Jardiff + Site included.
> >
> > [ ] +1
> > [ ] -1
> >
> > Vote to close on Monday if it gets that far.
> >
> > There is an open issue in JIRA currently:
> >
> > http://issues.apache.org/jira/browse/LANG-69
> >
> > I'm keeping it open for a little bit longer in case anyone has any
> > opinions on my fix to this.
> >
> > Hen
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Lang 2.3 RC1
Posted by Stephen Colebourne <sc...@btopenworld.com>.
Any chance you could unzip the site?
Stephen
Henri Yandell wrote:
> Next up - Lang 2.3.
>
> Here's the release candidate:
>
> http://people.apache.org/~bayard/commons-lang/commons-lang-2.3-rc1/
>
> Clirr, Jardiff + Site included.
>
> [ ] +1
> [ ] -1
>
> Vote to close on Monday if it gets that far.
>
> There is an open issue in JIRA currently:
>
> http://issues.apache.org/jira/browse/LANG-69
>
> I'm keeping it open for a little bit longer in case anyone has any
> opinions on my fix to this.
>
> Hen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org