You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by mulhoon <gi...@git.apache.org> on 2014/10/11 19:54:04 UTC

[GitHub] cordova-plugin-splashscreen pull request: Fix for portrait/landsca...

GitHub user mulhoon opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/29

    Fix for portrait/landscape detection

    Sometimes the width can be 568 or 320 depending on orientation on iPhone 5. This fixes the detection.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mulhoon/cordova-plugin-splashscreen patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
    
----
commit 1aad512624f1cc525a83717b0050e859398fae3f
Author: Nic Mulvaney <ni...@nicmulvaney.com>
Date:   2014-10-11T17:53:40Z

    Fix for portrait/landscape detection
    
    Sometimes the width can be 568 or 320 depending on orientation on iPhone 5. This fixes the detection.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: Fix for portrait/landsca...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/29#issuecomment-58968040
  
    Pulled in: https://github.com/apache/cordova-plugin-splashscreen/commit/2f37eed1840619c31f5fdc746cbf9324ef6afb53
    
    You can close this PR now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org