[jira] [Comment Edited] (HBASE-20214) Review of RegionLocationFinder Class

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402619#comment-16402619 ] 

Ted Yu edited comment on HBASE-20214 at 3/16/18 10:03 PM:
----------------------------------------------------------

{code}
-        LOG.debug("HDFSBlocksDistribution not found in cache for region "
-            + hri.getRegionNameAsString());
-        blockDistbn = internalGetTopBlockLocation(hri);
{code}
The corresponding logic for {{internalGetTopBlockLocation}} after the change is in {{load}} / {{reload}} ?




was (Author: yuzhihong@gmail.com):
{code}
-        LOG.debug("HDFSBlocksDistribution not found in cache for region "
-            + hri.getRegionNameAsString());
-        blockDistbn = internalGetTopBlockLocation(hri);
{code}
Where is the corresponding logic for {{internalGetTopBlockLocation}} after the change ?



> Review of RegionLocationFinder Class
> ------------------------------------
>
>                 Key: HBASE-20214
>                 URL: https://issues.apache.org/jira/browse/HBASE-20214
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer, master
>    Affects Versions: 2.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HBASE-20214.1.patch
>
>
> # Use SLF4J parameter logging
>  # Remove superfluous code
>  # Replace code with re-usable libraries where possible
>  # Use different data structure
>  # Small perf improvements
>  # Fix some checkstyle



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)