You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/29 01:05:42 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #4010: MINOR: Generate expected benchmark query results
andygrove opened a new pull request, #4010:
URL: https://github.com/apache/arrow-datafusion/pull/4010
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
We really need to start checking that the benchmark queries are producing the correct results
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Update tpch-gen.sh to:
- Use an available docker image instead of maintaining our own
- Write the expected query results (at SF=1) into `./data/answers`
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #4010: MINOR: Generate expected benchmark query results
Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #4010:
URL: https://github.com/apache/arrow-datafusion/pull/4010#issuecomment-1295797942
Looks great. I tried running the tests now against SF=1. I also had SF=10 running, but that one fails with more (my feeling is mostly rounding / overflow errors) and quite slow to read the files in CSV format.
This is what I get with `TPCH_DATA=./tpch-dbgen/ cargo test --release -- --test-threads=1`
```
running 66 tests
test tests::q1 ... ok
test tests::q10 ... ok
test tests::q10_expected_plan ... ok
test tests::q11 ... FAILED
test tests::q11_expected_plan ... ok
test tests::q12 ... ok
test tests::q12_expected_plan ... ok
test tests::q13 ... ok
test tests::q13_expected_plan ... ok
test tests::q14 ... FAILED
test tests::q14_expected_plan ... ok
test tests::q15 ... ok
test tests::q15_expected_plan ... ok
test tests::q16 ... ok
test tests::q16_expected_plan ... ok
test tests::q17 ... FAILED
test tests::q17_expected_plan ... ignored
test tests::q18 ... ok
test tests::q18_expected_plan ... ok
test tests::q19 ... ok
test tests::q19_expected_plan ... ok
test tests::q1_expected_plan ... ok
test tests::q2 ... ok
test tests::q20 ... ok
test tests::q20_expected_plan ... ok
test tests::q21 ... ok
test tests::q21_expected_plan ... ok
test tests::q22 ... ok
test tests::q22_expected_plan ... ok
test tests::q2_expected_plan ... ok
test tests::q3 ... ok
test tests::q3_expected_plan ... ok
test tests::q4 ... ok
test tests::q4_expected_plan ... ok
test tests::q5 ... ok
test tests::q5_expected_plan ... ok
test tests::q6 ... FAILED
test tests::q6_expected_plan ... ok
test tests::q7 ... ok
test tests::q7_expected_plan ... ok
test tests::q8 ... ok
test tests::q8_expected_plan ... ok
test tests::q9 ... FAILED
test tests::q9_expected_plan ... ok
test tests::run_q1 ... ok
test tests::run_q10 ... ok
test tests::run_q11 ... ok
test tests::run_q12 ... ok
test tests::run_q13 ... ok
test tests::run_q14 ... ok
test tests::run_q15 ... ok
test tests::run_q16 ... ok
test tests::run_q17 ... ok
test tests::run_q18 ... ok
test tests::run_q19 ... ok
test tests::run_q2 ... ok
test tests::run_q20 ... ok
test tests::run_q21 ... ok
test tests::run_q22 ... ok
test tests::run_q3 ... ok
test tests::run_q4 ... ok
test tests::run_q5 ... ok
test tests::run_q6 ... ok
test tests::run_q7 ... ok
test tests::run_q8 ... ok
test tests::run_q9 ... ok
failures:
---- tests::q11 stdout ----
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 11, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
Query 11 iteration 0 took 824.6 ms and returned 29571 rows
Query 11 avg time: 824.63 ms
thread 'main' panicked at 'assertion failed: `(left == right)`
left: `1048`,
right: `29571`', benchmarks/src/bin/tpch.rs:1411:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- tests::q14 stdout ----
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 14, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
Query 14 iteration 0 took 2749.8 ms and returned 1 rows
Query 14 avg time: 2749.84 ms
thread 'main' panicked at 'assertion failed: schema_matches', benchmarks/src/bin/tpch.rs:1404:13
---- tests::q17 stdout ----
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 17, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
Query 17 iteration 0 took 9599.6 ms and returned 1 rows
Query 17 avg time: 9599.62 ms
thread 'main' panicked at 'assertion failed: schema_matches', benchmarks/src/bin/tpch.rs:1404:13
---- tests::q6 stdout ----
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 6, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
Query 6 iteration 0 took 2957.9 ms and returned 1 rows
Query 6 avg time: 2957.93 ms
thread 'main' panicked at 'assertion failed: `(left == right)`
left: `["123141078.23"]`,
right: `["75207429.08"]`', benchmarks/src/bin/tpch.rs:1415:17
---- tests::q9 stdout ----
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 9, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
Query 9 iteration 0 took 3962.8 ms and returned 175 rows
Query 9 avg time: 3962.77 ms
thread 'main' panicked at 'assertion failed: `(left == right)`
left: `["MOROCCO", "1997", "42698382.85"]`,
right: `["MOROCCO", "1997", "42698382.86"]`', benchmarks/src/bin/tpch.rs:1415:17
failures:
tests::q11
tests::q14
tests::q17
tests::q6
tests::q9
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4010: MINOR: Generate expected benchmark query results
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4010:
URL: https://github.com/apache/arrow-datafusion/pull/4010#issuecomment-1295820886
Benchmark runs are scheduled for baseline = 345234550712173477e7807ba2cf67dd2ffb9ed5 and contender = 71f05a3175e931943276a8778162e37504e00503. 71f05a3175e931943276a8778162e37504e00503 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/39af42b8fb5c4c47a8b1c3af51d29d4c...9fdebdc77f264af6aeb5acc2600526d6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a1d84573bf5a4b2c8fdce8a646e22eff...48ae9298657f45089d9b8e3fa9ad3fe2/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bc07167193cb4eb1bd5021934b40c6cf...722e1871bde7427fb7b43f7b4168d439/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9cd872f6ce3843d3bfd193deb8f9d157...47ef0c77ffbf449e9c765f3f86dfdbbb/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #4010: MINOR: Generate expected benchmark query results
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #4010:
URL: https://github.com/apache/arrow-datafusion/pull/4010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #4010: MINOR: Generate expected benchmark query results
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #4010:
URL: https://github.com/apache/arrow-datafusion/pull/4010#issuecomment-1295818993
Thanks for the review. This matches what I am seeing. My goal for today is to get these tests running in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org