You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lewiszlw (via GitHub)" <gi...@apache.org> on 2024/07/09 09:31:23 UTC

[PR] Add begin/end_transaction methods in FlightSqlServiceClient [arrow-rs]

lewiszlw opened a new pull request, #6026:
URL: https://github.com/apache/arrow-rs/pull/6026

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   `FlightSqlService` suppots transaction feature, so add some helper methods for client.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add begin/end_transaction methods in FlightSqlServiceClient [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6026:
URL: https://github.com/apache/arrow-rs/pull/6026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add begin/end_transaction methods in FlightSqlServiceClient [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6026:
URL: https://github.com/apache/arrow-rs/pull/6026#issuecomment-2226841388

   >  I added a test in flight_sql_client_cli.rs. (maybe could move to a new file flight_sql_client.rs)
   
   Yeah, it seems like  flight_sql_client_cli.rs is slowly becoming the test for the `FlightSqlServiceClient` -- I agree reaming it and starting to cover all the FlightSQL methods might be good 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add begin/end_transaction methods in FlightSqlServiceClient [arrow-rs]

Posted by "lewiszlw (via GitHub)" <gi...@apache.org>.
lewiszlw commented on PR #6026:
URL: https://github.com/apache/arrow-rs/pull/6026#issuecomment-2225152390

   I added a test in `flight_sql_client_cli.rs`. (maybe could move to a new file `flight_sql_client.rs`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add begin/end_transaction methods in FlightSqlServiceClient [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6026:
URL: https://github.com/apache/arrow-rs/pull/6026#issuecomment-2228785248

   Thanks again @lewiszlw 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add begin/end_transaction methods in FlightSqlServiceClient [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6026:
URL: https://github.com/apache/arrow-rs/pull/6026#discussion_r1673902844


##########
arrow-flight/src/sql/client.rs:
##########
@@ -399,6 +403,54 @@ impl FlightSqlServiceClient<Channel> {
         ))
     }
 
+    /// Request to begin a transaction.
+    pub async fn begin_transaction(&mut self) -> Result<Bytes, ArrowError> {

Review Comment:
   I was wondering if there were any parameters that should be passed to this function, but I see the underlying message doesn't have any either so this makes sense to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add begin/end_transaction methods in FlightSqlServiceClient [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6026:
URL: https://github.com/apache/arrow-rs/pull/6026#discussion_r1676798683


##########
arrow-flight/tests/flight_sql_client_cli.rs:
##########
@@ -318,244 +358,6 @@ impl FlightSqlService for FlightSqlServiceImpl {
         Ok(resp)
     }
 
-    async fn get_flight_info_substrait_plan(

Review Comment:
   this all have default impls, so it is ok to remove them, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add begin/end_transaction methods in FlightSqlServiceClient [arrow-rs]

Posted by "lewiszlw (via GitHub)" <gi...@apache.org>.
lewiszlw commented on code in PR #6026:
URL: https://github.com/apache/arrow-rs/pull/6026#discussion_r1676824024


##########
arrow-flight/tests/flight_sql_client_cli.rs:
##########
@@ -318,244 +358,6 @@ impl FlightSqlService for FlightSqlServiceImpl {
         Ok(resp)
     }
 
-    async fn get_flight_info_substrait_plan(

Review Comment:
   Yes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org