You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Collins-Sussman <su...@collab.net> on 2004/10/07 15:32:04 UTC

problem with r11262

Log message says:

------------------------------------------------------------------------
r11262 | lundblad | 2004-10-06 15:53:59 -0500 (Wed, 06 Oct 2004) | 7  
lines
Changed paths:
    M /trunk/subversion/libsvn_ra_local/split_url.c

Fix issue #2012, allow URI-encoded drive letter an colon or pipe  
character
for ra_local URLs on Win32.

* libsvn_ra_local/split_url.c (svn_ra_local__split_URL): URI-decode the  
path
   before checking for drive followed by : or |, so that this part can be
   URI_encoded.

------------------------------------------------------------------------


But this seems to have broken my win32 nightly tests.
The initial import is choking:

------------------
START: basic_tests.py
CMD: svnadmin.exe "create" "local_tmp\repos" "--bdb-txn-nosync" <TIME
= 1.860000>
CMD: svn.exe "import" "--username" "jrandom" "--password" "rayjandom"
"-m" "Log message for revision 1." "local_tmp\greekfiles"
"file:///D:/svnbuild/src-trunk/Release/subversion/tests/clients/ 
cmdline/local_tmp/repos"
"--config-dir"
"D:\svnbuild\src- 
trunk\Release\subversion\tests\clients\cmdline\local_tmp\config"
<TIME = 0.828000>
svn: Unable to open an ra_local session to URL
svn: Unable to open repository
------------------


It looks like our parsing of win32 drive letters no longer works:


---------------

D:\svnbuild\distributions\svn-win32-trunk\bin>.\svnadmin create d:\repos

D:\svnbuild\distributions\svn-win32-trunk\bin>.\svn ls file:///D:/repos
svn: URL 'file:///D:/repos' non-existent in that revision

D:\svnbuild\distributions\svn-win32-trunk\bin>.\svn ls  
"file:///D|/repos"
svn: URL 'file:///D%7C/repos' non-existent in that revision

D:\svnbuild\distributions\svn-win32-trunk\bin>.\svn ls  
"file:///D:/repos"
svn: URL 'file:///D:/repos' non-existent in that revision

---------------


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: problem with r11262

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Thu, 7 Oct 2004, Ben Collins-Sussman wrote:

> Log message says:
>
> ------------------------------------------------------------------------
> r11262 | lundblad | 2004-10-06 15:53:59 -0500 (Wed, 06 Oct 2004) | 7
> lines
> Changed paths:
>     M /trunk/subversion/libsvn_ra_local/split_url.c
>
> Fix issue #2012, allow URI-encoded drive letter an colon or pipe
> character
> for ra_local URLs on Win32.
>
> * libsvn_ra_local/split_url.c (svn_ra_local__split_URL): URI-decode the
> path
>    before checking for drive followed by : or |, so that this part can be
>    URI_encoded.
>
> ------------------------------------------------------------------------
>
>
> But this seems to have broken my win32 nightly tests.
> The initial import is choking:
>
Sorry (again). I start to see a pattern... Hope it is fixed now.

(At least it worked at work...)

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: problem with r11262

Posted by Simon Large <sl...@blazepoint.co.uk>.
"Ben Collins-Sussman" wrote
>
> On Oct 7, 2004, at 2:24 PM, Simon Large wrote:
>
> >
> > "Ben Collins-Sussman" wrote
> >> But this seems to have broken my win32 nightly tests.
> >> It looks like our parsing of win32 drive letters no longer works:
> >
> > Can the nightly tests also include UNC paths so that issue 2011 (when
> > it is
> > fixed) doesn't slip through.
>
> Would you like to write a new python test for that?  :-)

Sorree, no speakee python :-(




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: problem with r11262

Posted by Ben Collins-Sussman <su...@collab.net>.
On Oct 7, 2004, at 2:24 PM, Simon Large wrote:

>
> "Ben Collins-Sussman" wrote
>> But this seems to have broken my win32 nightly tests.
>> It looks like our parsing of win32 drive letters no longer works:
>
> Can the nightly tests also include UNC paths so that issue 2011 (when 
> it is
> fixed) doesn't slip through.

Would you like to write a new python test for that?  :-)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: problem with r11262

Posted by Simon Large <sl...@blazepoint.co.uk>.
"Ben Collins-Sussman" wrote
> But this seems to have broken my win32 nightly tests.
> It looks like our parsing of win32 drive letters no longer works:

Can the nightly tests also include UNC paths so that issue 2011 (when it is
fixed) doesn't slip through.

Simon




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org