You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/18 00:32:25 UTC
[GitHub] [airflow] kaxil opened a new pull request #17674: Dev: Remove duplicate step to push Docker Image
kaxil opened a new pull request #17674:
URL: https://github.com/apache/airflow/pull/17674
We have the same step few lines below "## Prepare production Docker Image"
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins merged pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
jhtimmins merged pull request #17674:
URL: https://github.com/apache/airflow/pull/17674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691069881
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
https://github.com/astronomer/airflow/blob/067738926c75148b21a41d94b48fcb5c57b9d0db/dev/README_RELEASE_AIRFLOW.md#prepare-production-docker-image
https://github.com/astronomer/airflow/blob/067738926c75148b21a41d94b48fcb5c57b9d0db/dev/README_RELEASE_AIRFLOW.md#manually-prepare-production-docker-image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691067036
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
Nope, then make it 3 :)
We already have another section for oushing after Vote too
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
Check under RC section and then check under Publish final version :) - so definitely not a good reason ;)
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
Check under RC section and then check under Publish final version :)
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
https://github.com/astronomer/airflow/blob/067738926c75148b21a41d94b48fcb5c57b9d0db/dev/README_RELEASE_AIRFLOW.md#prepare-production-docker-image
https://github.com/astronomer/airflow/blob/067738926c75148b21a41d94b48fcb5c57b9d0db/dev/README_RELEASE_AIRFLOW.md#manually-prepare-production-docker-image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#issuecomment-900734527
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691068116
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
Check under RC section and then check under Publish final version :) - so definitely not a good reason ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691068116
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
Check under RC section and then check under Publish final version :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691067036
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
Nope, then make it 3 :)
We already have another section for oushing after Vote too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691096810
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
:D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691097217
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
RIGHT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691054542
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
@kaxil @jhtimmins The main reason it was twice, because those were two different images (first was RC and the second was final one) :). I see tha tthe RC was prepared and pushed eventually anyway, But at least we should link to the common step rather than remove it from "RC" part as it is good for users to verify (I do it as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691054542
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
@kaxil @jhtimmins The main reason it was twice, because those were two different images (first was RC and the second was final one) :). I see tha tthe RC was prepared and pushed eventually anyway, But at least we should link to the common step rather than remove it from "RC" part as it is good for users to verify (I do it as well)
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
:D
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker Image](#manually-prepare-production-docker-image)
Review comment:
RIGHT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#issuecomment-900734527
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins merged pull request #17674: Dev: Remove duplicate step to push Docker Image
Posted by GitBox <gi...@apache.org>.
jhtimmins merged pull request #17674:
URL: https://github.com/apache/airflow/pull/17674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org