[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2544: issues#1946 add [Druid] Source & Sink

[GitBox <gi...@apache.org>]

Hisoka-X commented on code in PR #2544:
URL: https://github.com/apache/incubator-seatunnel/pull/2544#discussion_r962510627


##########
config/spark.streaming.conf.template:
##########
@@ -26,7 +26,7 @@ env {
   spark.executor.instances = 2
   spark.executor.cores = 1
   spark.executor.memory = "1g"
-  spark.stream.batchDuration = 5
+  spark.streaming.batchDuration = 5

Review Comment:
   Please check this https://github.com/apache/incubator-seatunnel/pull/2575



##########
docs/zh-CN/spark/quick-start.md:
##########
@@ -34,7 +34,7 @@ ln -s seatunnel-<version> seatunnel
 ```bash
 env {
   # seatunnel defined streaming batch duration in seconds
-  spark.stream.batchDuration = 5

Review Comment:
   same as above



##########
pom.xml:
##########
@@ -204,6 +204,11 @@
         <p3c-pmd.version>1.3.0</p3c-pmd.version>
         <maven-scm-provider-jgit.version>1.9.5</maven-scm-provider-jgit.version>
         <testcontainer.version>1.16.3</testcontainer.version>
+        <jackson-datatype-joda.version>2.12.1</jackson-datatype-joda.version>

Review Comment:
   Don't add the connector's dependency in root pom, just use it in connector's pom.xml, reference: https://github.com/apache/incubator-seatunnel/pull/2630/files



##########
seatunnel-apis/seatunnel-api-spark/src/main/scala/org/apache/seatunnel/spark/stream/SparkStreamingExecution.scala:
##########
@@ -48,12 +48,9 @@ class SparkStreamingExecution(sparkEnvironment: SparkEnvironment)
             dataset)
         }
         var ds = dataset
-
-        if (ds.take(1).length > 0) {

Review Comment:
   Can't delete this, check this: https://github.com/apache/incubator-seatunnel/pull/2578



##########
docs/en/connector-v2/sink/Druid.md:
##########
@@ -0,0 +1,101 @@
+# Druid

Review Comment:
   Please update doc to match new format, reference: https://github.com/apache/incubator-seatunnel/pull/2625



##########
docs/en/contribution/setup.md:
##########
@@ -35,12 +35,6 @@ Otherwise, your code could not start in JetBrains IntelliJ IDEA correctly.
 ./mvnw install -Dmaven.test.skip
 ```
 
-### Building SeaTunnel from source

Review Comment:
   Why remove this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org