You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/12/03 13:03:36 UTC
[GitHub] leventov commented on a change in pull request #6662:
Double-checked locking bugs
leventov commented on a change in pull request #6662: Double-checked locking bugs
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r238259200
##########
File path: processing/src/main/java/org/apache/druid/query/aggregation/JavaScriptAggregatorFactory.java
##########
@@ -285,14 +291,17 @@ public String toString()
*/
private void checkAndCompileScript()
Review comment:
Please make it to return a value. Rename to getCompiledScript(). `@EnsuresNonNull("compiledScript")`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org