You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Erez Nahir (JIRA)" <ji...@codehaus.org> on 2008/02/07 19:58:30 UTC
[jira] Created: (SUREFIRE-452) suitename always = "TestSuite" even
if defined as property
suitename always = "TestSuite" even if <suitename> defined as property
----------------------------------------------------------------------
Key: SUREFIRE-452
URL: http://jira.codehaus.org/browse/SUREFIRE-452
Project: Maven Surefire
Issue Type: Bug
Components: TestNG support
Affects Versions: 2.4.1, 2.4
Environment: Maven version: 2.0.8
Java version: 1.5.0_14
OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
and also on Linux
Reporter: Erez Nahir
Attachments: TestNGDirectoryTestSuite.java
Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
Here is the configuration in my pom file:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.4.1</version>
<configuration>
<testFailureIgnore>true</testFailureIgnore>
<groups>fast</groups>
<excludedgroups>broken</excludedgroups>
<properties>
<property>
<name>suitename</name>
<value>${artifactId}</value>
</property>
<property>
<name>testname</name>
<value>${artifactId}</value>
</property>
</properties>
</configuration>
</plugin>
There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-452) suitename always = "TestSuite"
even if defined as property
Posted by "Erez Nahir (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123473 ]
Erez Nahir commented on SUREFIRE-452:
-------------------------------------
Any chance to deploy current fix soon? perhaps as 2.4.1.1 or 2.4.2?
We are blocked in this issue.
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Fix For: 2.x
>
> Attachments: TestNGDirectoryTestSuite.java, TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-452) suitename always = "TestSuite"
even if defined as property
Posted by "Erez Nahir (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123977 ]
Erez Nahir commented on SUREFIRE-452:
-------------------------------------
First, thanks for applying this patch, it will allow me to move to surefire as soon as 2.4.2 gets out.
I'll save you the story why in a 100+ engineers team with 100+ maven components, this is a blocking issue, but believe me, without it, I can use surefire (although I agree it's not broken).
Thanks again.
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Fix For: 2.4.2
>
> Attachments: TestNGDirectoryTestSuite.java, TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-452) suitename always = "TestSuite"
even if defined as property
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123962 ]
Dan Fabulich commented on SUREFIRE-452:
---------------------------------------
Two points.
1) I find it hard to believe that you're "blocked" by this bug. Yes, it's certainly annoying that everything gets dumped into a file called TestSuite.xml. But that's only bothering you because of a bug in JUnitReport where it only pays attention to the name of the file, instead of paying attention to the "classname" attribute inside the XML file. http://issues.apache.org/bugzilla/show_bug.cgi?id=24106
JUnitReport is kinda broken. May I recommend our fine Surefire Report instead?
2) I just attempted to test your revised patch, and I didn't entirely grasp the intended effect of this code. This code doesn't do anything *except* honor the "suitename" option if you forcibly pass it in. Naturally, you can only do this on a per-project basis.
I don't think this really helps you very much. All test results are going to go into one file, and because of Ant bug 24106, all test results will be reported as coming from one class. Does it matter whether the file is called "TestSuite" or whether it's called ${artifactId}? You still won't be able to tell what class had a test failure.
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Fix For: 2.x
>
> Attachments: TestNGDirectoryTestSuite.java, TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-452) suitename always = "TestSuite"
even if defined as property
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123168 ]
Dan Fabulich commented on SUREFIRE-452:
---------------------------------------
Hmmm... Just reviewing this, I note that it only works with a directory test suite, but not when a suite.xml file is specified... I think it should probably work correctly in both cases...?
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Fix For: 2.x
>
> Attachments: TestNGDirectoryTestSuite.java, TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (SUREFIRE-452) suitename always = "TestSuite" even
if defined as property
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Fabulich closed SUREFIRE-452.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.x)
2.4.2
Ah, whatever. I fixed your patch to make it work with XML suites and submitted it in revision revision 628192. It will go out in 2.4.2.
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Fix For: 2.4.2
>
> Attachments: TestNGDirectoryTestSuite.java, TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SUREFIRE-452) suitename always = "TestSuite" even
if defined as property
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Fabulich updated SUREFIRE-452:
----------------------------------
Fix Version/s: 2.x
Targeting for 2.x (this won't block 2.4.2 coming out) but if you can provide another patch that passes the tests, I'll probably accept it.
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Fix For: 2.x
>
> Attachments: TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-452) suitename always = "TestSuite"
even if defined as property
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122859 ]
Dan Fabulich commented on SUREFIRE-452:
---------------------------------------
I reproduce the problem, but I find that the integration test TestNgSuiteXmlTest fails when I apply this patch:
{noformat}
org.apache.maven.surefire.booter.SurefireExecutionException: org.apache.maven.surefire.testng.TestNGXmlTestSuite; nested exception is java.lang.ClassCastException: org.apache.maven.surefire.testng.TestNGXmlTestSuite
java.lang.ClassCastException: org.apache.maven.surefire.testng.TestNGXmlTestSuite
at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.startTestSuite(TestNGDirectoryTestSuite.java:166)
at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:91)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:338)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:997)
{noformat}
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Attachments: TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SUREFIRE-452) suitename always = "TestSuite" even
if defined as property
Posted by "Erez Nahir (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erez Nahir updated SUREFIRE-452:
--------------------------------
Attachment: TestNGDirectoryTestSuite.java
This is an updated fix checking first if suite can be casted.
All tests have passed with this one.
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Fix For: 2.x
>
> Attachments: TestNGDirectoryTestSuite.java, TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SUREFIRE-452) suitename always = "TestSuite"
even if defined as property
Posted by "Erez Nahir (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123174 ]
Erez Nahir commented on SUREFIRE-452:
-------------------------------------
Yep, I agree.
But in our configuration, we are not using suite.xml. So, I did not even tried to fix it.
I'll try to take a look, but I don't think my current fix should not be in, just because suite.xml is broken.
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Fix For: 2.x
>
> Attachments: TestNGDirectoryTestSuite.java, TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira