[GitHub] huaxingao commented on a change in pull request #23676: [SPARK-26754][PYTHON] Add hasTrainingSummary to replace duplicate code in PySpark

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #23676: [SPARK-26754][PYTHON] Add hasTrainingSummary to replace duplicate code in PySpark
URL: https://github.com/apache/spark/pull/23676#discussion_r253144779
 
 

 ##########
 File path: python/pyspark/ml/clustering.py
 ##########
 @@ -141,7 +132,7 @@ def summary(self):
         training set. An exception is thrown if no summary exists.
 
 Review comment:
   @srowen Thank you very much for your review. I think I still need  the ```summary``` implementation here, because I need to cast the ```super.summary``` to ```GaussianMixtureSummary```. If I remove the implementation, the unit test will fail. 
   I checked the scala code, it also has ```summary``` implementation in the specific subclass. Seems removing the implementation will have error too. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org