[GitHub] [doris] weizhengte commented on a diff in pull request #8861: [feature-wip](statistics) step4: collect statistics by implementing statistics tasks

[GitBox <gi...@apache.org>]

weizhengte commented on code in PR #8861:
URL: https://github.com/apache/doris/pull/8861#discussion_r914574487


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyzeStmt.java:
##########
@@ -60,47 +60,50 @@
  *      properties: properties of statistics jobs
  */
 public class AnalyzeStmt extends DdlStmt {
-    private static final Logger LOG = LogManager.getLogger(AnalyzeStmt.class);
-
-    // time to wait for collect  statistics
+    /** time to wait for collect  statistics */
     public static final String CBO_STATISTICS_TASK_TIMEOUT_SEC = "cbo_statistics_task_timeout_sec";
 
     private static final ImmutableSet<String> PROPERTIES_SET = new ImmutableSet.Builder<String>()
             .add(CBO_STATISTICS_TASK_TIMEOUT_SEC)
             .build();
 
-    public static final Predicate<Long> DESIRED_TASK_TIMEOUT_SEC = (v) -> v > 0L;
+    private static final Predicate<Long> DESIRED_TASK_TIMEOUT_SEC = (v) -> v > 0L;
 
     private final TableName dbTableName;
+    private final PartitionNames partitionNames;
     private final List<String> columnNames;
     private final Map<String, String> properties;
 
     // after analyzed
     private long dbId;
     private final Set<Long> tblIds = Sets.newHashSet();
 
-    public AnalyzeStmt(TableName dbTableName, List<String> columns, Map<String, String> properties) {
+    public AnalyzeStmt(TableName dbTableName,
+            List<String> columns,
+            PartitionNames partitionNames,

Review Comment:
   I did not add the corresponding semantic parsing code to this PR. I plan to add all the SQL syntax related to statistical information at the end. The following getPartitionNames method is actually reserved because the syntax parsing has not yet been implemented, otherwise, it may occur exceptions when referenced elsewhere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org