You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/22 00:29:06 UTC
[GitHub] bersprockets commented on issue #23864:
[SPARK-26851][SQL][FOLLOWUP] Fix cachedColumnBuffers field for Scala 2.11
build
bersprockets commented on issue #23864: [SPARK-26851][SQL][FOLLOWUP] Fix cachedColumnBuffers field for Scala 2.11 build
URL: https://github.com/apache/spark/pull/23864#issuecomment-466224589
lgtm. I was a little worried about ```cacheBuilder.copy(cachedPlan = plan)``` not wiping out ```_cachedColumnBuffers```, but a quick test of case classes shows that it will.
Maybe @maropu wants to take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org