You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/06 14:55:35 UTC
[GitHub] [kafka] rajinisivaram commented on a change in pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)
rajinisivaram commented on a change in pull request #9345:
URL: https://github.com/apache/kafka/pull/9345#discussion_r500359056
##########
File path: clients/src/test/java/org/apache/kafka/common/network/CertStores.java
##########
@@ -54,13 +60,30 @@ public CertStores(boolean server, String commonName, InetAddress hostAddress) th
}
private CertStores(boolean server, String commonName, TestSslUtils.CertificateBuilder certBuilder) throws Exception {
+ this(server, commonName, "RSA", certBuilder, false);
+ }
+
+ private CertStores(boolean server, String commonName, String keyAlgorithm, TestSslUtils.CertificateBuilder certBuilder, boolean usePem) throws Exception {
String name = server ? "server" : "client";
Mode mode = server ? Mode.SERVER : Mode.CLIENT;
- File truststoreFile = File.createTempFile(name + "TS", ".jks");
- sslConfig = TestSslUtils.createSslConfig(!server, true, mode, truststoreFile, name, commonName, certBuilder);
+ File truststoreFile = usePem ? null : File.createTempFile(name + "TS", ".jks");
+ sslConfig = new SslConfigsBuilder(mode)
+ .useClientCert(!server)
+ .certAlias(name)
+ .cn(commonName)
+ .createNewTrustStore(truststoreFile)
+ .certBuilder(certBuilder)
+ .algorithm(keyAlgorithm)
+ .usePem(usePem)
+ .build();
}
+
public Map<String, Object> getTrustingConfig(CertStores truststoreConfig) {
+ return getTrustingConfig(truststoreConfig, false);
+ }
+
+ public Map<String, Object> getTrustingConfig(CertStores truststoreConfig, boolean usePemCerts) {
Review comment:
removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org