You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/10 08:51:26 UTC

[GitHub] [spark] fan31415 commented on a change in pull request #28487: [SPARK-31671][ML] Wrong error message in VectorAssembler

fan31415 commented on a change in pull request #28487:
URL: https://github.com/apache/spark/pull/28487#discussion_r422612573



##########
File path: mllib/src/test/scala/org/apache/spark/ml/feature/VectorAssemblerSuite.scala
##########
@@ -261,4 +261,14 @@ class VectorAssemblerSuite
     val output = vectorAssembler.transform(dfWithNullsAndNaNs)
     assert(output.select("a").limit(1).collect().head == Row(Vectors.sparse(0, Seq.empty)))
   }
+  test("SPARK-31671: should give explicit error message when can not infer column lengths") {

Review comment:
       OK done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org