You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Jakob Homan (Created) (JIRA)" <ji...@apache.org> on 2012/02/08 02:04:59 UTC
[jira] [Created] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
_hadoopBsp should be prefixable via configuration
-------------------------------------------------
Key: GIRAPH-142
URL: https://issues.apache.org/jira/browse/GIRAPH-142
Project: Giraph
Issue Type: Improvement
Reporter: Jakob Homan
Assignee: Jakob Homan
In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205099#comment-13205099 ]
Avery Ching commented on GIRAPH-142:
------------------------------------
Jakob, your 'if(' still needs to be 'if ('. =) Reviewing would be easier with multiple revisions with rb. Helps me to see only the recent changes.
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.2.0
>
> Attachments: GIRAPH-142-b.patch, GIRAPH-142-c.patch, GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Jakob Homan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated GIRAPH-142:
-------------------------------
Attachment: GIRAPH-142-c.patch
Updated with formatting changes.
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.2.0
>
> Attachments: GIRAPH-142-b.patch, GIRAPH-142-c.patch, GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Claudio Martella (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205048#comment-13205048 ]
Claudio Martella commented on GIRAPH-142:
-----------------------------------------
looks good. +1.
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.2.0
>
> Attachments: GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205068#comment-13205068 ]
Avery Ching commented on GIRAPH-142:
------------------------------------
whoops, should have also said that the if () block should have braces
i.e.
{noformat}
+ public static String getBasePath(Configuration conf) {
+ String result = conf.get(BASE_ZNODE_KEY, "");
+ if (!result.equals("") && !result.startsWith("/")) {
+ throw new IllegalArgumentException("Value for " +
+ BASE_ZNODE_KEY + " must start with /: " + result);
+ }
+
+ return result;
+ }
+
{noformat}
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.2.0
>
> Attachments: GIRAPH-142-b.patch, GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Jakob Homan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated GIRAPH-142:
-------------------------------
Attachment: GIRAPH-142.patch
Patch to add new config value, giraph.zkBaseZNode, that is the top-level for all giraph-created content on the ZK server. New unit test. Verified on running cluster as well.
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.2.0
>
> Attachments: GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205047#comment-13205047 ]
Avery Ching commented on GIRAPH-142:
------------------------------------
Looks fine, could we just add a check somewhere that the path must start with "/" and throw an exception explaining to the user the problem?
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.2.0
>
> Attachments: GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205066#comment-13205066 ]
Avery Ching commented on GIRAPH-142:
------------------------------------
+1
Some minor formatting changes (spacing and 'if('):
{noformat}
+ public static String getBasePath(Configuration conf) {
+ String result = conf.get(BASE_ZNODE_KEY, "");
+ if(!result.equals("") && !result.startsWith("/"))
+ throw new IllegalArgumentException("Value for " +
+ BASE_ZNODE_KEY + " must start with /: " + result);
+
+ return result;
+ }
+
{noformat}
should be
{noformat}
+ public static String getBasePath(Configuration conf) {
+ String result = conf.get(BASE_ZNODE_KEY, "");
+ if (!result.equals("") && !result.startsWith("/"))
+ throw new IllegalArgumentException("Value for " +
+ BASE_ZNODE_KEY + " must start with /: " + result);
+
+ return result;
+ }
+
{noformat}
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.2.0
>
> Attachments: GIRAPH-142-b.patch, GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203882#comment-13203882 ]
Avery Ching commented on GIRAPH-142:
------------------------------------
So you're talking about making
public static final String BASE_DIR = "/_hadoopBsp";
configurable right? This would be good.
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Reporter: Jakob Homan
> Assignee: Jakob Homan
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Jakob Homan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203893#comment-13203893 ]
Jakob Homan commented on GIRAPH-142:
------------------------------------
Right. That way, on shared zookeepers, all the Giraph-related content can be dropped into /giraph, or whatever. This will be useful if we end up with more content in zk, which is likely to happen. I'll have a patch shortly.
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Reporter: Jakob Homan
> Assignee: Jakob Homan
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Jakob Homan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205105#comment-13205105 ]
Jakob Homan commented on GIRAPH-142:
------------------------------------
I'll fix it in my next patch.
bq. Reviewing would be easier with multiple revisions with rb.
But posting patches becomes much, much harder... This is a checkstyle issue, not an rb issue.
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.2.0
>
> Attachments: GIRAPH-142-b.patch, GIRAPH-142-c.patch, GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-142) _hadoopBsp should be prefixable via
configuration
Posted by "Jakob Homan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated GIRAPH-142:
-------------------------------
Attachment: GIRAPH-142-b.patch
Updated patch with check for starting slash.
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
> Key: GIRAPH-142
> URL: https://issues.apache.org/jira/browse/GIRAPH-142
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.2.0
>
> Attachments: GIRAPH-142-b.patch, GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory that's created for the _hadoopBsp znodes. This would also fix the issue we have with creating that directory in the source root during tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira