You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/04/20 14:21:42 UTC

[GitHub] [parquet-mr] gszadovszky commented on pull request #895: Parquet-2030: Expose page size row check configurations to ParquetWri…

gszadovszky commented on pull request #895:
URL: https://github.com/apache/parquet-mr/pull/895#issuecomment-823315022


   Yeah, checking only that properties are really passed is not easy. I did not want to say to remove all the tests completely (or any) just that we don't need to test every aspect of the original feature. I think, it is enough to test the difference between setting the properties and not so you know they are passed. You can see that passing such properties are not that obvious so I would keep some test to be sure.
   
   The idea of checking the number of row groups is a good point. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org