You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/21 03:01:48 UTC

[GitHub] [flink] dianfu opened a new pull request #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types

dianfu opened a new pull request #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types
URL: https://github.com/apache/flink/pull/8817
 
 
   ## What is the purpose of the change
   
   *The following API registerTableSink in TableEnvironment has been deprecated at Java side:*
   `@Deprecated
   void registerTableSink(String name, String[] fieldNames, TypeInformation<?>[] fieldTypes, TableSink<?> tableSink);`
   *We should drop support of it in Python Table API.*
   
   ## Brief change log
   
     - *Remove the parameters field_names and field_types in register_table_sink*
     - *Update TestTableSink to make it accept field_names and field_types as parameters and configure the Java TableSink during constructing the Java TableSink*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *StreamTableEnvironmentTests*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services