[jira] [Commented] (ARTEMIS-4710) Keep pem-keystore dependencies as is; make it really optional

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833260#comment-17833260 ] 

ASF subversion and git services commented on ARTEMIS-4710:
----------------------------------------------------------

Commit bf1ea4128775c97e6c6fc6a0ab6921feaf8197d5 in activemq-artemis's branch refs/heads/main from Alexey Markevich
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=bf1ea41287 ]

ARTEMIS-4710 Keep pem-keystore dependencies as is; make it really
optional

The latest version already uses bcprov-jdk18on.
Avoid global imports to be able to exclude dependency when not used.

> Keep pem-keystore dependencies as is; make it really optional
> -------------------------------------------------------------
>
>                 Key: ARTEMIS-4710
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4710
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.33.0
>            Reporter: Alexey Markevich
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Previously we excluded bcprov-jdk15on and bcpkix-jdk15on dependencies normally used by pem-keystore, and replaced them with bcprov-jdk18on and bcpkix-jdk18on as already managed and used elsewhere in the build, thus keeping things consistent on a single gav for the bc modules.
> The latest 2.3.0 version of pem-keystore (used since ARTEMIS-4599) was actually changed to use bcprov-jdk18on and bcpkix-jdk18on in https://github.com/ctron/pem-keystore/commit/1263b207da0adf4a7d2dc61d6a9a19e7bba97731. As such we can now simplify the dependency handling by removing the prior exclusion+replacement handling for those deps.
> Additionally, by avoiding a global import on PemKeyStoreProvider, and only referencing it upon use, those who wish would be able to exclude the dependency when the functionality is not used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)