You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by asavartsov <gi...@git.apache.org> on 2016/06/01 23:31:45 UTC

[GitHub] flink pull request #2062: [FLINK-4000] Fix for checkpoint state restore at M...

GitHub user asavartsov opened a pull request:

    https://github.com/apache/flink/pull/2062

    [FLINK-4000] Fix for checkpoint state restore at MessageAcknowledgingSourceBase

    As says documentation for MessageAcknowledgingSourceBase.restoreState() 
    
    This method is invoked when a function is executed as part of a recovery run. Note that restoreState() is called before open().
    
    So current implementation
    
    1. Fails on restoreState with NullPointerException, jobs fail to restart.
    2. Does not restore anything because following open erases all checkpoint data immediately.
    3. As consequence, violates exactly once rule because processed but not acknowledged list erased.
    
    Proposed change fixes that.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/asavartsov/flink FLINK-4000

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2062.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2062
    
----
commit 58fb7df0b2d1dd68a90f4088fbde10874eb290b6
Author: Alexey Savartsov <as...@gmail.com>
Date:   2016-06-01T23:23:53Z

    [FLINK-4000] Fix for checkpoint state restore at MessageAcknowledgingSourceBase
    
    As says documentation for MessageAcknowledgingSourceBase.restoreState() 
    
    This method is invoked when a function is executed as part of a recovery run. Note that restoreState() is called before open().
    
    So current implementation
    
    1. Fails on restoreState with NullPointerException, jobs fail to restart.
    2. Does not restore anything because following open erases all checkpoint data immediately.
    3. As consequence, violates exactly once rule because processed but not acknowledged list erased.
    
    Proposed change fixes that.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2062: [FLINK-4000] Fix for checkpoint state restore at M...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2062


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2062: [FLINK-4000] Fix for checkpoint state restore at MessageA...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2062
  
    Thanks, this is a critical fix.
    +1
    
    Merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---